Show correct alexa metadata categories for group items #767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Miguel <[email protected]>
GiviMAD
force-pushed
the
alexa-gruop-item-metadata
branch
from
0a89485 to
55a8780
Compare
Signed-off-by: Yannick Schaus <[email protected]>
ghys
approved these changes
Jan 8, 2021
There was a problem hiding this comment.
Thank you very much @GiviMAD for taking care of this!
I only added some linting fixes; make sure you run ESLint
(for instance with the VSCode extension) in the future.
See: #614 (comment)
and #208 (comment)
I should add this to the docs.
Regarding the functionality itself, I'll trust you, at first sight it seems to work well.
crnjan
added a commit
to crnjan/openhab-webui
that referenced
this pull request
Jan 9, 2021
* master: Inbox: Fix error when deleting, add ability to set custom ID (openhab#775) Show correct alexa metadata categories for group items (openhab#767) Don't show edit/save buttons in model if item is not editable (openhab#774) Only show list indexes on mobile devices (openhab#773) Consider alarms part of equipment in location glance badges (openhab#772) Consider blinds open when state is ON or 0 in blinds glance (openhab#771) Fix measurement badges display condition (openhab#770) Fallback to UIDs if things have no label during sorting (openhab#769) Fix personal widgets ordering (openhab#768)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aims to solve issue #511.
For items of type 'Group' disable multiple category selection and show the correct endpoint categories.
Hope this is an acceptable solution.
Thanks in advance.