Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BasicUI] Use more contrasted color buttons in widgets when in dark mode #1834

Merged
merged 1 commit into from
Apr 12, 2023

Conversation

lolodomo
Copy link
Contributor

@lolodomo lolodomo commented Apr 10, 2023

Applied to colopicker, setpoint, switch/rollerblind and switch/mappings widgets.

Also change the track color of the switch widget when state is OFF

Related to #1831

Signed-off-by: Laurent Garnier [email protected]

@lolodomo lolodomo added enhancement New feature or request basic ui Basic UI labels Apr 10, 2023
@lolodomo lolodomo requested a review from a team as a code owner April 10, 2023 13:40
@lolodomo lolodomo force-pushed the basicui_buttons_ctrl branch from 37954e0 to 4a48c54 Compare April 10, 2023 13:42
@lolodomo lolodomo changed the title [BasicUI] Used colored buttons for widget controls for better contrast [BasicUI] Use colored buttons for widget controls for better contrast Apr 10, 2023
@lolodomo
Copy link
Contributor Author

lolodomo commented Apr 10, 2023

Here is the new rendering:
image
image

Compared to before:
image
image

@lolodomo lolodomo force-pushed the basicui_buttons_ctrl branch from 4a48c54 to ad77f27 Compare April 10, 2023 14:09
@lolodomo lolodomo marked this pull request as draft April 10, 2023 16:00
@lolodomo lolodomo force-pushed the basicui_buttons_ctrl branch from ad77f27 to 62fae3c Compare April 10, 2023 16:41
@lolodomo lolodomo changed the title [BasicUI] Use colored buttons for widget controls for better contrast [BasicUI] Use more contrasted color buttons in widgets when in dark mode Apr 10, 2023
@lolodomo lolodomo marked this pull request as ready for review April 10, 2023 16:44
Applied to colopicker, setpoint, switch/rollerblind and switch/mappings widgets.

Also change the track color of the switch widget when state is OFF

Related to openhab#1831

Signed-off-by: Laurent Garnier <[email protected]>
@lolodomo lolodomo force-pushed the basicui_buttons_ctrl branch from 62fae3c to a530a4a Compare April 10, 2023 17:39
Copy link
Member

@kaikreuzer kaikreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kaikreuzer kaikreuzer merged commit 3f817ad into openhab:main Apr 12, 2023
@kaikreuzer kaikreuzer added this to the 4.0 milestone Apr 12, 2023
@lolodomo lolodomo deleted the basicui_buttons_ctrl branch April 12, 2023 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
basic ui Basic UI enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants