[BasicUI] Add the "follow system" theme #1829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes openhab#1828 3 themes are now available! bright, dark and system. Theme previously named "default" has been renamed into "bright". "default" is still accepted for backward compatibility. Tested with Fiorefox, Chrome and Edge on Windows 10. Tested with Chrome on Android. Signed-off-by: Laurent Garnier <[email protected]>
|
I have to update this PR now that PR #1834 has been merged. |
Signed-off-by: Laurent Garnier <[email protected]>
|
PR is again ready for review. |
kaikreuzer
requested changes
Apr 12, 2023
bundles/org.openhab.ui.basic/src/main/resources/OH-INF/config/config.xml
Outdated
Show resolved
Hide resolved
bundles/org.openhab.ui.basic/src/main/resources/OH-INF/i18n/basic.properties
Outdated
Show resolved
Hide resolved
Signed-off-by: Laurent Garnier <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1828
3 themes are now available! bright, dark and system.
Theme previously named "default" has been renamed into "bright".
"default" is still accepted for backward compatibility.
Tested with Fiorefox, Chrome and Edge on Windows 10.
Tested with Chrome on Android.
Signed-off-by: Laurent Garnier [email protected]