Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Item picker: load items when passed an empty array #1073

Merged
merged 1 commit into from
May 30, 2021
Merged

Item picker: load items when passed an empty array #1073

merged 1 commit into from
May 30, 2021

Conversation

ghys
Copy link
Member

@ghys ghys commented May 30, 2021

Fix #1062.

Signed-off-by: Yannick Schaus [email protected]

@ghys ghys requested a review from a team as a code owner May 30, 2021 07:59
@ghys ghys added this to the 3.1 milestone May 30, 2021
@ghys ghys added bug Something isn't working main ui Main UI labels May 30, 2021
@relativeci
Copy link

relativeci bot commented May 30, 2021

Job #135: Bundle Size — 10.4MB (~+0.01%).

8cedfe2 vs 6ca7fdb

Changed metrics (2/8)
Metric Current Baseline
Cache Invalidation 5.9% 26.9%
Duplicate Packages 17(+112.5%) 8
Changed assets by type (1/7)
            Current     Baseline
JS 8.14MB (~+0.01%) 8.14MB

View Job #135 report on app.relative-ci.com

@ghys ghys merged commit d08803b into main May 30, 2021
@hubsif
Copy link
Contributor

hubsif commented May 30, 2021

Hi!
I've had a quick look and my fix, waiting to be added to #1066 once you responded, looks somewhat different. I'll try to find the difference in result and if required share it here.

@ghys
Copy link
Member Author

ghys commented May 30, 2021

Yes sorry, #1062 needed an urgent fix since there's a milestone build scheduled for today and I have to run off for the day now. This PR focuses on addressing it with no other changes. Will address your comments in #1066 tonight.

@hubsif hubsif mentioned this pull request Jun 5, 2021
Closed
@ghys ghys deleted the item-picker-empty-array branch June 22, 2022 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working main ui Main UI
Projects
None yet
Milestone
3.1
Development

Successfully merging this pull request may close these issues.

[Main UI] Managed Items cannot be assigned to Groups in Item Edit page
2 participants
@ghys @hubsif