Fix group slider triggering change, fixes #789 #1001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hubert Nusser <[email protected]>
Job #77: Bundle Size — 10.45MB (-0.02%).Changed metrics (2/8)
|
hubsif
added a commit
to hubsif/openhab-webui
that referenced
this pull request
May 6, 2021
Signed-off-by: Hubert Nusser <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation:
Even with integer steps only for each member, a group can become a floating number (e.g. avg. 3 and 4 resulting in 3.5). The computed
valuethen is the floating number, which is different from the rounded slider value.Adjusting
toStepFixedto always compute andvalueto be rounded for the comparison inonChangeseemed to be enough to fix this.I wasn't able to find any relation to "rollershutters" like mentioned in #894, which has been closed as duplicate.