Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Widgets: don't send commands on external state changes #789

Closed
wookie666 opened this issue Jan 11, 2021 · 1 comment
Closed

Widgets: don't send commands on external state changes #789

wookie666 opened this issue Jan 11, 2021 · 1 comment
Labels
bug Something isn't working main ui Main UI

Comments

@wookie666
Copy link

Group Dimmer when using AV function of child items sends commands to all items on every update

Expected behavior

Group dimmer should control all items in group. But when you use average function to have it Update the state, it should only post update, and not send command.

I agree, that this seems to be the same issue, I did not see that the group-average were involved.

I was able to reproduce with four items (without any links):

item_group (group:Dimmer)
item1 (Dimmer)
item2 (Dimmer)
item3 (Dimmer)
The code of the UI page is:

config:
label: items
blocks:

  • component: oh-block
    config: {}
    slots:
    default:
    - component: oh-grid-cells
    config: {}
    slots:
    default:
    - component: oh-cell
    config:
    action: group
    actionGroupPopupItem: Item_goup
    masonry: null

Klicking on the cell opens the group “Item_goup” where you can control each item but also the group.

I changed only item1 to 85 but got:

2021-01-11 08:38:50.993 [INFO ] [openhab.event.ItemCommandEvent ] - Item 'Item1' received command 85
2021-01-11 08:38:51.004 [INFO ] [hab.event.GroupItemStateChangedEvent] - Item 'Item_goup' changed from 60.00000000 to 72.33333300 through Item1
2021-01-11 08:38:51.029 [INFO ] [openhab.event.ItemStateChangedEvent ] - Item 'Item1' changed from 48 to 85
2021-01-11 08:38:51.118 [INFO ] [openhab.event.ItemCommandEvent ] - Item 'Item_goup' received command 72
2021-01-11 08:38:51.123 [INFO ] [openhab.event.ItemCommandEvent ] - Item 'Item1' received command 72
2021-01-11 08:38:51.126 [INFO ] [openhab.event.ItemCommandEvent ] - Item 'Item2' received command 72
2021-01-11 08:38:51.128 [INFO ] [openhab.event.ItemCommandEvent ] - Item 'Item3' received command 72
2021-01-11 08:38:51.137 [INFO ] [hab.event.GroupItemStateChangedEvent] - Item 'Item_goup' changed from 72.33333300 to 68.00000000 through Item1
2021-01-11 08:38:51.138 [INFO ] [openhab.event.ItemStateChangedEvent ] - Item 'Item1' changed from 85 to 72
2021-01-11 08:38:51.140 [INFO ] [hab.event.GroupItemStateChangedEvent] - Item 'Item_goup' changed from 68.00000000 to 70.00000000 through Item2
2021-01-11 08:38:51.142 [INFO ] [openhab.event.ItemStateChangedEvent ] - Item 'Item2' changed from 66 to 72
2021-01-11 08:38:51.144 [INFO ] [hab.event.GroupItemStateChangedEvent] - Item 'Item_goup' changed from 70.00000000 to 72.00000000 through Item3
2021-01-11 08:38:51.147 [INFO ] [openhab.event.ItemStateChangedEvent ] - Item 'Item3' changed from 66 to 72

Please see post https://community.openhab.org/t/openhab-3-group-average-causing-weird-results/113651/7

@wookie666 wookie666 added bug Something isn't working main ui Main UI labels Jan 11, 2021
@ghys ghys changed the title Group Dimmer when using AV function of child items sends commands to all items on every update Don't send commands to groups if state changes because of a member Jan 14, 2021
@Rossko57
Copy link

Could rephrase the new title as "don't send any commands from a UI unless it is a user action". This issue may not be confined to Groups, I don't know.

@ghys ghys changed the title Don't send commands to groups if state changes because of a member Don't send commands on external state changes Jan 14, 2021
@ghys ghys changed the title Don't send commands on external state changes Widgets: don't send commands on external state changes Jan 14, 2021
hubsif added a commit to hubsif/openhab-webui that referenced this issue Apr 16, 2021
@ghys ghys closed this as completed in dd6e756 Apr 18, 2021
@Rossko57 Rossko57 mentioned this issue Apr 18, 2021
hubsif added a commit to hubsif/openhab-webui that referenced this issue May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working main ui Main UI
Projects
None yet
Development

No branches or pull requests

2 participants