-
-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[basicUI]: ipcamera videostream in basicUI sitemap throws exception #745
[basicUI]: ipcamera videostream in basicUI sitemap throws exception #745
Comments
Is it working with a sitemap created manually in a .sitemap file (not with MainUI) ? |
A video widget requires a mandatory url argument, something like: https://www.openhab.org/docs/configuration/sitemaps.html#element-type-video Issue to be closed (wrong sitemap syntax) or to be associated to MainUI rather than BasicUI if the problem is the sitezmap builder from MainUI. |
Unfortunately, it's the same when I add the URL to the element: Sitemap: Logfile:
When I put the video element into a .sitemap file and open the page, there is no exception: .sitemap-file:
I still don't see an image in the video control, but this might have other reasons I need to check. |
Ok, so this is not a Basic UI bug but rather a bug in the MainUI sitemap builder. |
This works for me if contained in a sitemap FILE and viewed in basicUI and the ios app. Note the encoding is added.
I have heard others say it does not work if stored in the JSON database and that putting it into a file fixes it, but I have not tried it myself to confirm. I am now mostly using a OH3 widget to display the feeds as it is much better as it has the ability to overlay controls and alarms on top of the feed. |
Encoding doesn't make a difference - it even fails when it's used too. But even if this had been the reason: To sum it up:
|
Also catch remaining exceptions and log a warning/ignore the parameter instead of making the whole sitemap building process fail. Fix wrong feature ID for the video widget URL. Fixes openhab#2047. Fixes openhab#1987. Fixes openhab#1898. Fixes openhab#1875. Fixes openhab/openhab-webui#745. Signed-off-by: Yannick Schaus <[email protected]>
Should be fixed by openhab/openhab-core#2072. |
@ghys: I guess this will solve this issue as well? |
Stupid question: How can I find out which PR is included in which build/snapshot? |
Yes, thanks.
Look at https://ci.openhab.org/job/openHAB-Core/changes and check that your distribution build was made after the build which included the commit you're after. openhab/openhab-core#2072 is not yet merged btw. |
@ghys , thank you! I did a quick check and used exactly the same sitemap in a .sitemap file and in a UI generated sitemap:
I don't get an exception anymore, but a completely different behaviour in basicUI, depending on where I created the sitemap: Do you think this different behaviour will be fixed as well? Thank you! |
…aps (#2072) * Fix parsing integer & booleans parameters in UI component based sitemaps Also catch remaining exceptions and log a warning/ignore the parameter instead of making the whole sitemap building process fail. Fix wrong feature ID for the video widget URL. Fixes #2047. Fixes #1987. Fixes #1898. Fixes #1875. Fixes openhab/openhab-webui#745. Signed-off-by: Yannick Schaus <[email protected]>
@kaikreuzer , @ghys : I updated now to build #2118 which should include #2072, but I still get an exception when using the MainUI generated sitemap to display the page with the video element inside:
|
...and when I try to use an image instead I don't get an exception, but also no image:
Doing the same in a .sitemap file there's no problem at all. |
…aps (#2072) * Fix parsing integer & booleans parameters in UI component based sitemaps Also catch remaining exceptions and log a warning/ignore the parameter instead of making the whole sitemap building process fail. Fix wrong feature ID for the video widget URL. Fixes #2047. Fixes #1987. Fixes #1898. Fixes #1875. Fixes openhab/openhab-webui#745. Signed-off-by: Yannick Schaus <[email protected]>
Hi, is it solved? I still get this issue after installing version 3.1.0 Build #2147. |
it works for me. Do you a) use the item provided by the channel and b) the video URL in parallel? |
Hi, I tried also using image widget instead of video but even if I get no error in the log I also get no image in the UI. sitemap page_a3a0449c28 label="New Sitemap" { where IP address is the openhab one and port is the one configured at things level. If I put the URL directly in the browser it works fine, if I put this sitemap code in a sitemap file it works fine.
|
I just look at web page source code to search for differences: the one created by the UI reports the following line for the image: img src="images/none.png" |
The missing image is related to another bug I filed an issue for: |
* Add site provider lookup in proxy Third attempt at this PR, but this very simply allows for the proxy to find the sitemaps for both file based as well as gui generated. Fixes #2154 Fixes openhab/openhab-webui#763 Fixes openhab/openhab-webui#745 Also-by: Kai Kreuzer <[email protected]> Signed-off-by: Brian Homeyer <[email protected]>
* Add site provider lookup in proxy Third attempt at this PR, but this very simply allows for the proxy to find the sitemaps for both file based as well as gui generated. Fixes #2154 Fixes openhab/openhab-webui#763 Fixes openhab/openhab-webui#745 Also-by: Kai Kreuzer <[email protected]> Signed-off-by: Brian Homeyer <[email protected]>
…aps (openhab#2072) * Fix parsing integer & booleans parameters in UI component based sitemaps Also catch remaining exceptions and log a warning/ignore the parameter instead of making the whole sitemap building process fail. Fix wrong feature ID for the video widget URL. Fixes openhab#2047. Fixes openhab#1987. Fixes openhab#1898. Fixes openhab#1875. Fixes openhab/openhab-webui#745. Signed-off-by: Yannick Schaus <[email protected]> GitOrigin-RevId: fcaf251
* Add site provider lookup in proxy Third attempt at this PR, but this very simply allows for the proxy to find the sitemaps for both file based as well as gui generated. Fixes openhab#2154 Fixes openhab/openhab-webui#763 Fixes openhab/openhab-webui#745 Also-by: Kai Kreuzer <[email protected]> Signed-off-by: Brian Homeyer <[email protected]> GitOrigin-RevId: 74c4c23
The problem
When going to a page within the basicUI sitemap containing the video element the following exceptions are being thrown:
Expected behavior
I expected the video stream to be shown on the page.
Steps to reproduce
Your environment
Browser console
Browser network traffic
Additional information
My IPCam is an INSTAR 9008 Full HD; the provided URL of the item can be opened an viewed at in any browser without any problem. This case was already mentioned here, but as I don't have the rights to move the issue to another repo, I reopened the case here: openhab/openhab-addons#9518
The text was updated successfully, but these errors were encountered: