Fix parsing integer & booleans parameters in UI component based sitemaps #2072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also catch remaining exceptions and log a warning/ignore the parameter instead of making the whole sitemap building process fail. Fix wrong feature ID for the video widget URL. Fixes openhab#2047. Fixes openhab#1987. Fixes openhab#1898. Fixes openhab#1875. Fixes openhab/openhab-webui#745. Signed-off-by: Yannick Schaus <[email protected]>
lolodomo
reviewed
Jan 4, 2021
...ore.ui/src/main/java/org/openhab/core/ui/internal/components/UIComponentSitemapProvider.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Yannick Schaus <[email protected]>
kaikreuzer
added
rebuild
wborn
added
rebuild
kaikreuzer
added
rebuild
kaikreuzer
approved these changes
Jan 5, 2021
cweitkamp
added
the
patch
cweitkamp
pushed a commit
that referenced
this pull request
Jan 10, 2021
…aps (#2072) * Fix parsing integer & booleans parameters in UI component based sitemaps Also catch remaining exceptions and log a warning/ignore the parameter instead of making the whole sitemap building process fail. Fix wrong feature ID for the video widget URL. Fixes #2047. Fixes #1987. Fixes #1898. Fixes #1875. Fixes openhab/openhab-webui#745. Signed-off-by: Yannick Schaus <[email protected]>
splatch
pushed a commit
to ConnectorIO/copybara-hab-core
that referenced
this pull request
Jul 11, 2023
…aps (openhab#2072) * Fix parsing integer & booleans parameters in UI component based sitemaps Also catch remaining exceptions and log a warning/ignore the parameter instead of making the whole sitemap building process fail. Fix wrong feature ID for the video widget URL. Fixes openhab#2047. Fixes openhab#1987. Fixes openhab#1898. Fixes openhab#1875. Fixes openhab/openhab-webui#745. Signed-off-by: Yannick Schaus <[email protected]> GitOrigin-RevId: fcaf251
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also catch remaining exceptions and log a warning/ignore the parameter
instead of making the whole sitemap building process fail.
Fix wrong feature ID for the video widget URL.
Fixes #2047.
Fixes #2005.
Fixes #1987.
Fixes #1898.
Fixes #1875.
Fixes openhab/openhab-webui#745.
Signed-off-by: Yannick Schaus [email protected]