Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BasicUI] New device setting to enable a bigger font size #2342

Closed
1 task done
lolodomo opened this issue Feb 10, 2024 · 0 comments · Fixed by #2243
Closed
1 task done

[BasicUI] New device setting to enable a bigger font size #2342

lolodomo opened this issue Feb 10, 2024 · 0 comments · Fixed by #2243
Labels
basic ui Basic UI enhancement New feature or request

Comments

@lolodomo
Copy link
Contributor

Which UI are you reporting an issue for?

  • Basic UI

The problem

Basic UI uses the default font size defined by Material Design Lite which is 14px for texts like sitemap element label and sitemap element value in particular.
On a phone with high resolution screen, texts could appear a little small. Users (not all of course) would appreciate a bigger font size. We need a setting to choose between the default font size and a bigger font size.

Your suggestion

Now that I have implemented local device settings for Basic UI (PR in review), my proposal is to add a new device setting to enable or disable a bigger font size. The default value will be "disabled" meaning the rendering will be unchanged (backward compatibility).
@lolodomo lolodomo added enhancement New feature or request basic ui Basic UI labels Feb 10, 2024
lolodomo added a commit to lolodomo/openhab-webui that referenced this issue Feb 11, 2024
@lolodomo
[BasicUI] Move most of app settings to per-device (browser) settings
fce51f7 
Closes openhab#1832
Closes openhab#1930
Closes openhab#2342

A new page is available to show and update all per-device settings. This page is accessible through the sitemap list page or the home page of any sitemap.
Basic UI theme now matches the dark mode of Main UI. It can be updated either in Main UI or in the new page of Baisc UI.
Web Audio can also be enabled either in Main UI or Basic UI.

The iconify setting is now enabled by default. The script to handle iconify icons is now loaded in sitemap pages only if the iconify setting is enabled.

New settings are also available to control the size of the chart and the size of content (text, line) in the chart.

A new setting is also available to enable a bigger font size.

Signed-off-by: Laurent Garnier <[email protected]>
@lolodomo lolodomo mentioned this issue Feb 11, 2024
Merged
lolodomo added a commit to lolodomo/openhab-webui that referenced this issue Feb 11, 2024
@lolodomo
[BasicUI] Move most of app settings to per-device (browser) settings
f3e9e54 
Closes openhab#1832
Closes openhab#1930
Closes openhab#2342

A new page is available to show and update all per-device settings. This page is accessible through the sitemap list page or the home page of any sitemap.
Basic UI theme now matches the dark mode of Main UI. It can be updated either in Main UI or in the new page of Baisc UI.
Web Audio can also be enabled either in Main UI or Basic UI.

The iconify setting is now enabled by default. The script to handle iconify icons is now loaded in sitemap pages only if the iconify setting is enabled.

New settings are also available to control the size of the chart and the size of content (text, line) in the chart.

A new setting is also available to enable a bigger font size.

Signed-off-by: Laurent Garnier <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
basic ui Basic UI enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[BasicUI] Move most of app settings to per-device (browser) settings lolodomo/openhab-webui
1 participant
@lolodomo