Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate per device MainUI and global BasicUI settings #1832

Closed
dilyanpalauzov opened this issue Apr 9, 2023 · 7 comments · Fixed by #2243
Closed

Consolidate per device MainUI and global BasicUI settings #1832

dilyanpalauzov opened this issue Apr 9, 2023 · 7 comments · Fixed by #2243
Labels
basic ui Basic UI enhancement New feature or request main ui Main UI

Comments

@dilyanpalauzov
Copy link

My understanding of the web interfaces in openHAB 3.4 so far is:

  • For MainUI any unauthenticated user can visit /about and setup the “Mode preferences”: Auto (System preference), Light, Dark; and the “Enable Web Audio sink support”. These settings are per device (per browser, actually)
  • The above settings are however irrelevant for BasicUI. To adjust the latter one has to visit /settings/services/org.openhab.basicui. Then the settings are not per device, but for all BasicUI instances, whereever they are loaded. Moreover to alter that settings the user has to authenticate towards openHAB.

For me these two-fold settings are contradicting each other. I suggest removing from the URL /settings/services/org.openhab.basicui the settings, which are duplicated from /about (like color mode and Web Audio sink preferences). Then use on the device where BasicUI is loaded the preferences set at /about. This will simplify things.

Moreover it would be good to be able set the default WebAudio (ON) for all devices. So that it is not necessary to enable it everywhere manually.

@dilyanpalauzov dilyanpalauzov added the enhancement New feature or request label Apr 9, 2023
@lolodomo
Copy link
Contributor

lolodomo commented Apr 9, 2023

I agree that the theme setting should be rather per device.
But I am not really in favour to make Basic UI suddenly depends on Main UI.

@ghys : can you tell me where are stored these per device Main UI settings ?

@lolodomo
Copy link
Contributor

lolodomo commented Apr 9, 2023

While I understand the idea to have the theme setting per device, I think it should be the same for WEB audio, for consistency.

@lolodomo
Copy link
Contributor

@florian-h05 : maybe you can explain how to retrieve these Main UI settings ?

@florian-h05
Copy link
Contributor

florian-h05 commented Apr 13, 2023

MainUI stores the theme settings in local browser storage, for dark/light/auto the key is org.openhab.ui:theme.dark:

localStorage.setItem('openhab.ui:theme.dark', value)

Valid values are light and dark, for auto the key-value pair is removed.

For WebAudio, see:

localStorage.setItem('openhab.ui:webaudio.enable', (value) ? 'enabled' : 'default')

Browser Dev Tools allow you to check content of local storage:
image

@lolodomo
Copy link
Contributor

Thank you @florian-h05

@lolodomo
Copy link
Contributor

Ok, I believe the proper solution would be to create a new settings page in Basic UI for settings that should be per device, and use the local browser storage.
For same settings as in Main UI, the same keys would be used.

@lolodomo lolodomo added basic ui Basic UI main ui Main UI labels Oct 7, 2023
@lolodomo
Copy link
Contributor

I plan to work on this very soon.

lolodomo added a commit to lolodomo/openhab-webui that referenced this issue Dec 29, 2023
Fix openhab#1832

A new page is available to show and update all per device settings.
This page is accessible through the sitemap list page or the home page
of any sitemap.
Basic UI theme now matches the dark mode of Main UI. It can be updated
either in Main UI or in the new page of Baisc UI.
Web Audio can also be enabled either in Main UI or Basic UI.

Signed-off-by: Laurent Garnier <[email protected]>
lolodomo added a commit to lolodomo/openhab-webui that referenced this issue Dec 29, 2023
Fix openhab#1832

A new page is available to show and update all per device settings.
This page is accessible through the sitemap list page or the home page
of any sitemap.
Basic UI theme now matches the dark mode of Main UI. It can be updated
either in Main UI or in the new page of Baisc UI.
Web Audio can also be enabled either in Main UI or Basic UI.

Signed-off-by: Laurent Garnier <[email protected]>
lolodomo added a commit to lolodomo/openhab-webui that referenced this issue Dec 30, 2023
Fix openhab#1832

A new page is available to show and update all per device settings.
This page is accessible through the sitemap list page or the home page
of any sitemap.
Basic UI theme now matches the dark mode of Main UI. It can be updated
either in Main UI or in the new page of Baisc UI.
Web Audio can also be enabled either in Main UI or Basic UI.

Signed-off-by: Laurent Garnier <[email protected]>
lolodomo added a commit to lolodomo/openhab-webui that referenced this issue Dec 31, 2023
Fix openhab#1832

A new page is available to show and update all per device settings.
This page is accessible through the sitemap list page or the home page
of any sitemap.
Basic UI theme now matches the dark mode of Main UI. It can be updated
either in Main UI or in the new page of Baisc UI.
Web Audio can also be enabled either in Main UI or Basic UI.

Signed-off-by: Laurent Garnier <[email protected]>
lolodomo added a commit to lolodomo/openhab-webui that referenced this issue Dec 31, 2023
Fix openhab#1832

A new page is available to show and update all per-device settings.
This page is accessible through the sitemap list page or the home page
of any sitemap.
Basic UI theme now matches the dark mode of Main UI. It can be updated
either in Main UI or in the new page of Baisc UI.
Web Audio can also be enabled either in Main UI or Basic UI.

Signed-off-by: Laurent Garnier <[email protected]>
lolodomo added a commit to lolodomo/openhab-webui that referenced this issue Jan 3, 2024
Fix openhab#1832

A new page is available to show and update all per-device settings. This page is accessible through the sitemap list page or the home page of any sitemap.
Basic UI theme now matches the dark mode of Main UI. It can be updated either in Main UI or in the new page of Baisc UI.
Web Audio can also be enabled either in Main UI or Basic UI.

Signed-off-by: Laurent Garnier <[email protected]>
lolodomo added a commit to lolodomo/openhab-webui that referenced this issue Jan 6, 2024
Fix openhab#1832

A new page is available to show and update all per-device settings. This page is accessible through the sitemap list page or the home page of any sitemap.
Basic UI theme now matches the dark mode of Main UI. It can be updated either in Main UI or in the new page of Baisc UI.
Web Audio can also be enabled either in Main UI or Basic UI.

Signed-off-by: Laurent Garnier <[email protected]>
lolodomo added a commit to lolodomo/openhab-webui that referenced this issue Feb 2, 2024
Fix openhab#1832

A new page is available to show and update all per-device settings. This page is accessible through the sitemap list page or the home page of any sitemap.
Basic UI theme now matches the dark mode of Main UI. It can be updated either in Main UI or in the new page of Baisc UI.
Web Audio can also be enabled either in Main UI or Basic UI.

New settings are also available to control the size of the chart and the size of text in chart.

Signed-off-by: Laurent Garnier <[email protected]>
lolodomo added a commit to lolodomo/openhab-webui that referenced this issue Feb 3, 2024
Fix openhab#1832

A new page is available to show and update all per-device settings. This page is accessible through the sitemap list page or the home page of any sitemap.
Basic UI theme now matches the dark mode of Main UI. It can be updated either in Main UI or in the new page of Baisc UI.
Web Audio can also be enabled either in Main UI or Basic UI.

New settings are also available to control the size of the chart and the size of text in chart.

Signed-off-by: Laurent Garnier <[email protected]>
lolodomo added a commit to lolodomo/openhab-webui that referenced this issue Feb 3, 2024
Fix openhab#1832

A new page is available to show and update all per-device settings. This page is accessible through the sitemap list page or the home page of any sitemap.
Basic UI theme now matches the dark mode of Main UI. It can be updated either in Main UI or in the new page of Baisc UI.
Web Audio can also be enabled either in Main UI or Basic UI.

New settings are also available to control the size of the chart and the size of text in chart.

Signed-off-by: Laurent Garnier <[email protected]>
lolodomo added a commit to lolodomo/openhab-webui that referenced this issue Feb 3, 2024
Fix openhab#1832

A new page is available to show and update all per-device settings. This page is accessible through the sitemap list page or the home page of any sitemap.
Basic UI theme now matches the dark mode of Main UI. It can be updated either in Main UI or in the new page of Baisc UI.
Web Audio can also be enabled either in Main UI or Basic UI.

New settings are also available to control the size of the chart and the size of text in chart.

Signed-off-by: Laurent Garnier <[email protected]>
lolodomo added a commit to lolodomo/openhab-webui that referenced this issue Feb 3, 2024
Fix openhab#1832

A new page is available to show and update all per-device settings. This page is accessible through the sitemap list page or the home page of any sitemap.
Basic UI theme now matches the dark mode of Main UI. It can be updated either in Main UI or in the new page of Baisc UI.
Web Audio can also be enabled either in Main UI or Basic UI.

New settings are also available to control the size of the chart and the size of text in chart.

Signed-off-by: Laurent Garnier <[email protected]>
lolodomo added a commit to lolodomo/openhab-webui that referenced this issue Feb 3, 2024
Fix openhab#1832

A new page is available to show and update all per-device settings. This page is accessible through the sitemap list page or the home page of any sitemap.
Basic UI theme now matches the dark mode of Main UI. It can be updated either in Main UI or in the new page of Baisc UI.
Web Audio can also be enabled either in Main UI or Basic UI.

New settings are also available to control the size of the chart and the size of text in chart.

Signed-off-by: Laurent Garnier <[email protected]>
lolodomo added a commit to lolodomo/openhab-webui that referenced this issue Feb 3, 2024
Fix openhab#1832

A new page is available to show and update all per-device settings. This page is accessible through the sitemap list page or the home page of any sitemap.
Basic UI theme now matches the dark mode of Main UI. It can be updated either in Main UI or in the new page of Baisc UI.
Web Audio can also be enabled either in Main UI or Basic UI.

New settings are also available to control the size of the chart and the size of text in chart.

Signed-off-by: Laurent Garnier <[email protected]>
lolodomo added a commit to lolodomo/openhab-webui that referenced this issue Feb 4, 2024
Fix openhab#1832

A new page is available to show and update all per-device settings. This page is accessible through the sitemap list page or the home page of any sitemap.
Basic UI theme now matches the dark mode of Main UI. It can be updated either in Main UI or in the new page of Baisc UI.
Web Audio can also be enabled either in Main UI or Basic UI.

New settings are also available to control the size of the chart and the size of text in chart.

Signed-off-by: Laurent Garnier <[email protected]>
lolodomo added a commit to lolodomo/openhab-webui that referenced this issue Feb 4, 2024
Fix openhab#1832

A new page is available to show and update all per-device settings. This page is accessible through the sitemap list page or the home page of any sitemap.
Basic UI theme now matches the dark mode of Main UI. It can be updated either in Main UI or in the new page of Baisc UI.
Web Audio can also be enabled either in Main UI or Basic UI.

New settings are also available to control the size of the chart and the size of text in chart.

Signed-off-by: Laurent Garnier <[email protected]>
lolodomo added a commit to lolodomo/openhab-webui that referenced this issue Feb 4, 2024
Fix openhab#1832

A new page is available to show and update all per-device settings. This page is accessible through the sitemap list page or the home page of any sitemap.
Basic UI theme now matches the dark mode of Main UI. It can be updated either in Main UI or in the new page of Baisc UI.
Web Audio can also be enabled either in Main UI or Basic UI.

New settings are also available to control the size of the chart and the size of text in chart.

Signed-off-by: Laurent Garnier <[email protected]>
lolodomo added a commit to lolodomo/openhab-webui that referenced this issue Feb 4, 2024
Fix openhab#1832

A new page is available to show and update all per-device settings. This page is accessible through the sitemap list page or the home page of any sitemap.
Basic UI theme now matches the dark mode of Main UI. It can be updated either in Main UI or in the new page of Baisc UI.
Web Audio can also be enabled either in Main UI or Basic UI.

New settings are also available to control the size of the chart and the size of text in chart.

Signed-off-by: Laurent Garnier <[email protected]>
lolodomo added a commit to lolodomo/openhab-webui that referenced this issue Feb 5, 2024
Fix openhab#1832

A new page is available to show and update all per-device settings. This page is accessible through the sitemap list page or the home page of any sitemap.
Basic UI theme now matches the dark mode of Main UI. It can be updated either in Main UI or in the new page of Baisc UI.
Web Audio can also be enabled either in Main UI or Basic UI.

New settings are also available to control the size of the chart and the size of text in chart.

Signed-off-by: Laurent Garnier <[email protected]>
lolodomo added a commit to lolodomo/openhab-webui that referenced this issue Feb 5, 2024
Fix openhab#1832

A new page is available to show and update all per-device settings. This page is accessible through the sitemap list page or the home page of any sitemap.
Basic UI theme now matches the dark mode of Main UI. It can be updated either in Main UI or in the new page of Baisc UI.
Web Audio can also be enabled either in Main UI or Basic UI.

New settings are also available to control the size of the chart and the size of text in chart.

Signed-off-by: Laurent Garnier <[email protected]>
lolodomo added a commit to lolodomo/openhab-webui that referenced this issue Feb 5, 2024
Fix openhab#1832

A new page is available to show and update all per-device settings. This page is accessible through the sitemap list page or the home page of any sitemap.
Basic UI theme now matches the dark mode of Main UI. It can be updated either in Main UI or in the new page of Baisc UI.
Web Audio can also be enabled either in Main UI or Basic UI.

New settings are also available to control the size of the chart and the size of text in chart.

Signed-off-by: Laurent Garnier <[email protected]>
lolodomo added a commit to lolodomo/openhab-webui that referenced this issue Feb 5, 2024
Fix openhab#1832

A new page is available to show and update all per-device settings. This page is accessible through the sitemap list page or the home page of any sitemap.
Basic UI theme now matches the dark mode of Main UI. It can be updated either in Main UI or in the new page of Baisc UI.
Web Audio can also be enabled either in Main UI or Basic UI.

New settings are also available to control the size of the chart and the size of text in chart.

Signed-off-by: Laurent Garnier <[email protected]>
lolodomo added a commit to lolodomo/openhab-webui that referenced this issue Feb 7, 2024
Fix openhab#1832
Closes openhab#1930

A new page is available to show and update all per-device settings. This page is accessible through the sitemap list page or the home page of any sitemap.
Basic UI theme now matches the dark mode of Main UI. It can be updated either in Main UI or in the new page of Baisc UI.
Web Audio can also be enabled either in Main UI or Basic UI.

New settings are also available to control the size of the chart and the size of content (text, line) in the chart.

Signed-off-by: Laurent Garnier <[email protected]>
lolodomo added a commit to lolodomo/openhab-webui that referenced this issue Feb 7, 2024
Fix openhab#1832
Closes openhab#1930

A new page is available to show and update all per-device settings. This page is accessible through the sitemap list page or the home page of any sitemap.
Basic UI theme now matches the dark mode of Main UI. It can be updated either in Main UI or in the new page of Baisc UI.
Web Audio can also be enabled either in Main UI or Basic UI.

New settings are also available to control the size of the chart and the size of content (text, line) in the chart.

Signed-off-by: Laurent Garnier <[email protected]>
lolodomo added a commit to lolodomo/openhab-webui that referenced this issue Feb 7, 2024
Fix openhab#1832
Closes openhab#1930

A new page is available to show and update all per-device settings. This page is accessible through the sitemap list page or the home page of any sitemap.
Basic UI theme now matches the dark mode of Main UI. It can be updated either in Main UI or in the new page of Baisc UI.
Web Audio can also be enabled either in Main UI or Basic UI.

New settings are also available to control the size of the chart and the size of content (text, line) in the chart.

Signed-off-by: Laurent Garnier <[email protected]>
lolodomo added a commit to lolodomo/openhab-webui that referenced this issue Feb 8, 2024
Fix openhab#1832
Closes openhab#1930

A new page is available to show and update all per-device settings. This page is accessible through the sitemap list page or the home page of any sitemap.
Basic UI theme now matches the dark mode of Main UI. It can be updated either in Main UI or in the new page of Baisc UI.
Web Audio can also be enabled either in Main UI or Basic UI.

The iconify setting is now enabled by default. The script to handle iconify icons is now loaded in sitemap pages only if the iconify setting is enabled.

New settings are also available to control the size of the chart and the size of content (text, line) in the chart.

Signed-off-by: Laurent Garnier <[email protected]>
lolodomo added a commit to lolodomo/openhab-webui that referenced this issue Feb 11, 2024
Closes openhab#1832
Closes openhab#1930
Closes openhab#2342

A new page is available to show and update all per-device settings. This page is accessible through the sitemap list page or the home page of any sitemap.
Basic UI theme now matches the dark mode of Main UI. It can be updated either in Main UI or in the new page of Baisc UI.
Web Audio can also be enabled either in Main UI or Basic UI.

The iconify setting is now enabled by default. The script to handle iconify icons is now loaded in sitemap pages only if the iconify setting is enabled.

New settings are also available to control the size of the chart and the size of content (text, line) in the chart.

A new setting is also available to enable a bigger font size.

Signed-off-by: Laurent Garnier <[email protected]>
lolodomo added a commit to lolodomo/openhab-webui that referenced this issue Feb 11, 2024
Closes openhab#1832
Closes openhab#1930
Closes openhab#2342

A new page is available to show and update all per-device settings. This page is accessible through the sitemap list page or the home page of any sitemap.
Basic UI theme now matches the dark mode of Main UI. It can be updated either in Main UI or in the new page of Baisc UI.
Web Audio can also be enabled either in Main UI or Basic UI.

The iconify setting is now enabled by default. The script to handle iconify icons is now loaded in sitemap pages only if the iconify setting is enabled.

New settings are also available to control the size of the chart and the size of content (text, line) in the chart.

A new setting is also available to enable a bigger font size.

Signed-off-by: Laurent Garnier <[email protected]>
kaikreuzer pushed a commit that referenced this issue Mar 3, 2024
…2243)

Closes #1832
Closes #1930
Closes #2342

A new page is available to show and update all per-device settings. This
page is accessible through the sitemap list page or the home page of any
sitemap.
Basic UI theme now matches the dark mode of Main UI. It can be updated
either in Main UI or in the new page of Baisc UI.
Web Audio can also be enabled either in Main UI or Basic UI.

The iconify setting is now enabled by default. The script to handle
iconify icons is now loaded in sitemap pages only if the iconify setting
is enabled.

New settings are also available to control the size of the chart and the
size of content (text, line) in the chart.

A new setting is also available to enable a bigger font size.

Signed-off-by: Laurent Garnier <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
basic ui Basic UI enhancement New feature or request main ui Main UI
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants