[actions] Add Transformation Actions as a class & Add arg type checking lib #180
Conversation
Signed-off-by: Florian Hotze <[email protected]>
This adds a Transformation class to explicitely allow access to the Transformation Actions, which were dynamically exported before. Signed-off-by: Florian Hotze <[email protected]>
Signed-off-by: Florian Hotze <[email protected]>
Signed-off-by: Florian Hotze <[email protected]>
Signed-off-by: Florian Hotze <[email protected]>
florian-h05
added
documentation
florian-h05
changed the title
|
@jpg0 Can you review? |
florian-h05
changed the title
florian-h05
changed the title
|
@digitaldan @jpg0 Can one of you please review so we can get this merged before the 3.4.0 feature freeze? |
|
I would prefer that the Transformation class is pulled out into it's own file, but whatever, that can be done later. |
|
Does the failing check matter here? I don't know how the docs system works. |
In this case, no I expect that failure. It is caused, because I reference the JSDoc for the Transformation class from the README. The JSDoc it references is not available online yet, it will be when this PR is merged and JSDoc updates. |
Signed-off-by: Florian Hotze <[email protected]>
|
@jpg0 Can we merge then? |
|
FYI the inverse of this work: transformations using ES6 - has not yet been implemented, and still uses Nashorn. |
|
You refer to the JavaScript Transformation service, right? |
|
Oh wow, there's lots of progress there that I wasn't aware of. Thanks for the pointer. |
|
@jpg0 I’ll add a section to our README to document the usage of JS Scripting for transformations. |
This adds the unit tests for openhab#180. Signed-off-by: Florian Hotze <[email protected]>
* [test] Add tests for actions.Transformation This adds the unit tests for #180. * [test] Address review for actions.Transformation tests Signed-off-by: Florian Hotze <[email protected]>
Fixes #100.
Description
typeof-argumentsmodule to allow easy type checking of function arguments (reference also to Errorjava.lang.IllegalArgumentException: Invalid type '{com.oracle.truffle.polyglot.PolyglotMap}' of configuration value!does not show its location in the .js file #176)Bundle-size increases from 852 KB to 868 KB, which is really not much.