Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[miio] add alert on miio channels changing #1247

Merged
merged 3 commits into from
Feb 27, 2021
Merged

[miio] add alert on miio channels changing #1247

merged 3 commits into from
Feb 27, 2021

Conversation

marcelrv
Copy link
Contributor

related to ao openhab/openhab-addons#9756 and openhab/openhab-addons#9384

Signed-off-by: Marcel Verpaalen [email protected]

@marcelrv marcelrv requested a review from a team as a code owner January 13, 2021 22:49
kaikreuzer
kaikreuzer requested changes Jan 14, 2021
View reviewed changes
Copy link
Member

@kaikreuzer kaikreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: Is this really a breaking change?
It should always be possible to link a dimensionless item to such a channel, so ideally this should be backward compatible.

distributions/openhab/src/main/resources/bin/update.lst Outdated Show resolved Hide resolved
@marcelrv
Copy link
Contributor Author

Question: Is this really a breaking change?
It should always be possible to link a dimensionless item to such a channel, so ideally this should be backward compatible.

To be honest I'm still not 100% clear indeed if it is breaking or not. I recall I had some issues with rules after the change overs.
Nevertheless, I'm very fine with the rewording you did.

Base automatically changed from master to main January 18, 2021 20:06
@marcelrv marcelrv requested a review from kaikreuzer February 10, 2021 19:17
kaikreuzer
kaikreuzer approved these changes Feb 27, 2021
View reviewed changes
Copy link
Member

@kaikreuzer kaikreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kaikreuzer kaikreuzer merged commit 2c51b0a into openhab:main Feb 27, 2021
@wborn wborn added this to the 3.1 milestone May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaikreuzer kaikreuzer kaikreuzer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.1
Development

Successfully merging this pull request may close these issues.
3 participants
@marcelrv @kaikreuzer @wborn