Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[miio] Update many channels with tags, categories & QuantityTypes #9384

Merged
merged 8 commits into from
Dec 28, 2020
Merged

[miio] Update many channels with tags, categories & QuantityTypes #9384

merged 8 commits into from
Dec 28, 2020

Conversation

marcelrv
Copy link
Contributor

Signed-off-by: Marcel Verpaalen [email protected]

@marcelrv marcelrv added enhancement An enhancement or new feature for an existing add-on about to close Issue potentially resolved and no feedback received labels Dec 15, 2020
@marcelrv marcelrv requested a review from cpmeister December 15, 2020 00:02
@marcelrv marcelrv removed the about to close Issue potentially resolved and no feedback received label Dec 15, 2020
cpmeister
cpmeister reviewed Dec 15, 2020
View reviewed changes
bundles/org.openhab.binding.miio/src/main/resources/database/huayi.light.fanwy2-miot.json Outdated
@@ -192,7 +196,7 @@
"piid": 3,
"friendlyName": "Presets - Pre Brightness",
"channel": "pre-brightness",
"type": "Number:Dimensionless",
"type": "Dimmer",
"unit": "percentage",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are units still used if you use a Dimmer instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my testing it does not seem to harm.
But... I did notice when I use in the item formatting %unit% it does not accept that for a dimmer,
so there is no value in having the unit specified.
Hence I removed the units from the dimmers now.

@marcelrv
[miio] remove unit from dimmers
e514788 
Signed-off-by: Marcel Verpaalen <[email protected]>
@marcelrv
Copy link
Contributor Author

Do you see any possibility to have this still in the build.
I was hoping this could be in the first OH3 release so that when folks upgrade they have the new channels from the gekko.

@marcelrv marcelrv added the bug An unexpected problem or unintended behavior of an add-on label Dec 16, 2020
@marcelrv
Copy link
Contributor Author

Also it fixes all the value mappings in the readme which may cause some confusion

@marcelrv
[miio] fix readmecomment
45becb2 
Signed-off-by: Marcel Verpaalen <[email protected]>
@cpmeister
Copy link
Contributor

We are in a feature freeze for the new release. So we are only allowing bug fixes for now.

@marcelrv
Copy link
Contributor Author

I'll separate the fix of readme items from this PR than to fix the documentation prior to the release

@marcelrv
Copy link
Contributor Author

the bug part of this has now been separated out of this PR and entered as separate PR #9402.
Once that one is merged, I'll update this PR to fix the created automatic merge issue

@marcelrv marcelrv removed the bug An unexpected problem or unintended behavior of an add-on label Dec 17, 2020
@marcelrv
merge
b41959a 
Signed-off-by: Marcel Verpaalen <[email protected]>
@marcelrv
merge
0c0826b 
Signed-off-by: Marcel Verpaalen <[email protected]>
@cpmeister
Copy link
Contributor

Can you resolve the conflicts?

@marcelrv
Merge branch 'main' into miio-updateChannels
3258e30 
Signed-off-by: Marcel Verpaalen <[email protected]>
@marcelrv
[miio] update readme
b41402e 
Signed-off-by: Marcel Verpaalen <[email protected]>
@marcelrv
Copy link
Contributor Author

@cpmeister yes, they should be fixed now. I think it is good to go again

@marcelrv marcelrv added the rebuild Triggers Jenkins PR build label Dec 23, 2020
@cpmeister cpmeister removed the rebuild Triggers Jenkins PR build label Dec 24, 2020
@cpmeister cpmeister merged commit 03dd4d4 into openhab:main Dec 28, 2020
@cpmeister cpmeister added this to the 3.1 milestone Dec 28, 2020
@marcelrv
Copy link
Contributor Author

sorry I missed your message.
Indeed I did not change line ending. Instead I moved the list of devices below the main text as I recognized many folks did not read any further. Hopefully now esp the FAQ is more easily found.

@marcelrv marcelrv deleted the miio-updateChannels branch December 28, 2020 18:12
seaside1 pushed a commit to seaside1/openhab-addons that referenced this pull request Dec 28, 2020
@marcelrv @seaside1
[miio] Update many channels with tags, categories & QuantityTypes (op…
00e5a65 
…enhab#9384)

* [miio] Update many channels with tags, categories & QuantityTypes
* [miio] remove unit from dimmers
* [miio] fix readme mappings for channels

Signed-off-by: Marcel Verpaalen <[email protected]>
seaside1 pushed a commit to seaside1/openhab-addons that referenced this pull request Dec 28, 2020
@marcelrv @seaside1
[miio] Update many channels with tags, categories & QuantityTypes (op…
964c1c0 
…enhab#9384)

* [miio] Update many channels with tags, categories & QuantityTypes
* [miio] remove unit from dimmers
* [miio] fix readme mappings for channels

Signed-off-by: Marcel Verpaalen <[email protected]>
Signed-off-by: Joseph Hagberg <[email protected]>
@marcelrv marcelrv mentioned this pull request Jan 13, 2021
Merged
thinkingstone pushed a commit to thinkingstone/openhab-addons that referenced this pull request Nov 7, 2021
@marcelrv @thinkingstone
[miio] Update many channels with tags, categories & QuantityTypes (op…
9c16065 
…enhab#9384)

* [miio] Update many channels with tags, categories & QuantityTypes
* [miio] remove unit from dimmers
* [miio] fix readme mappings for channels

Signed-off-by: Marcel Verpaalen <[email protected]>
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
@marcelrv
[miio] Update many channels with tags, categories & QuantityTypes (op…
4e79d39 
…enhab#9384)

* [miio] Update many channels with tags, categories & QuantityTypes
* [miio] remove unit from dimmers
* [miio] fix readme mappings for channels

Signed-off-by: Marcel Verpaalen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpmeister cpmeister cpmeister approved these changes

Assignees
No one assigned
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Milestone
3.1
Development

Successfully merging this pull request may close these issues.
2 participants
@marcelrv @cpmeister