[core] Added units kvarh and kvar #695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also simplified gravity unit. Signed-off-by: Hilbrand Bouwkamp <[email protected]>
|
Out of curiosity, how will those units be used? The description on wikiperia is not really informative for people like me who are not electrical engineers :) |
|
Here is an explanation using the 🍺 analogy 😄 These units are used for a new smart meter thing. Where the meter gives those values. |
|
@wborn or @cweitkamp can one of you have a look. It is now blocking my dsmr pr and thus blocking migrating the dsmr binding to bnd. |
cweitkamp
reviewed
Apr 6, 2019
| @@ -82,8 +84,8 @@ | |||
|
|
|||
| // Alphabetical ordered by Unit. | |||
| public static final Unit<Acceleration> METRE_PER_SQUARE_SECOND = addUnit(Units.METRE_PER_SQUARE_SECOND); | |||
| public static final Unit<Acceleration> STANDARD_GRAVITY = new TransformedUnit<>("gₙ", | |||
There was a problem hiding this comment.
Don't we loose the symbol "g" when applying this.
cweitkamp
approved these changes
Apr 7, 2019
cweitkamp
added
enhancement
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/preparation-for-2-5m2/75738/1 |
cweitkamp
changed the title
Rosi2143
pushed a commit
to Rosi2143/openhab-core
that referenced
this pull request
Dec 26, 2020
Signed-off-by: Chris Jackson <[email protected]>
splatch
pushed a commit
to ConnectorIO/copybara-hab-core
that referenced
this pull request
Jul 11, 2023
Also simplified gravity unit. Signed-off-by: Hilbrand Bouwkamp <[email protected]> GitOrigin-RevId: 1d8b7be
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also simplified gravity unit.