[dsmr] Added support for the Luxembourgian Smart Meter "Smarty" #5273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is based on the DSMR protocol but with encrypted messages. Also some improvements to the thing defintion files for missing bridges and some small code improvements. Signed-off-by: Hilbrand Bouwkamp <[email protected]>
|
This looks like a general improvement of code quality for this binding. I have performed a non-functional review and couldn't find any issues (and I don't want to nitpick here, the rather large test decrypt table could of course have been outsourced into a bundle resource, but nothing serious).
Because the core merge rate is super (s)low I suggest to not wait for core here and move those types later on. The bnd migration has higher priority.
Can you do that so that we can merge? |
Signed-off-by: Hilbrand Bouwkamp <[email protected]>
davidgraeff
approved these changes
Apr 3, 2019
Signed-off-by: Hilbrand Bouwkamp <[email protected]>
Signed-off-by: Hilbrand Bouwkamp <[email protected]>
Hilbrand
changed the title
Hilbrand
changed the title
Signed-off-by: Hilbrand Bouwkamp <[email protected]>
Signed-off-by: Hilbrand Bouwkamp <[email protected]>
Closed
|
Note: until openhab/openhab-core#695 has been merged the pr build will fail. |
Hilbrand
added
rebuild
Signed-off-by: Hilbrand Bouwkamp <[email protected]>
J-N-K
added
rebuild
J-N-K
approved these changes
Apr 9, 2019
mherwege
pushed a commit
to mherwege/openhab-addons
that referenced
this pull request
May 10, 2019
…hab#5273) * Added support for the Luxembourgian Smart Meter "Smarty" This is based on the DSMR protocol but with encrypted messages. Also some improvements to the thing defintion files for missing bridges and some small code improvements. * Updated readme. * Removed dependency on DatatypeConverter * Fixed SAT warnings. * Switched to units added to core. * Cleanup unit test. * Fix null warnings. Signed-off-by: Hilbrand Bouwkamp <[email protected]>
Pshatsillo
pushed a commit
to Pshatsillo/openhab-addons
that referenced
this pull request
Jun 19, 2019
…hab#5273) * Added support for the Luxembourgian Smart Meter "Smarty" This is based on the DSMR protocol but with encrypted messages. Also some improvements to the thing defintion files for missing bridges and some small code improvements. * Updated readme. * Removed dependency on DatatypeConverter * Fixed SAT warnings. * Switched to units added to core. * Cleanup unit test. * Fix null warnings. Signed-off-by: Hilbrand Bouwkamp <[email protected]> Signed-off-by: Pshatsillo <[email protected]>
ne0h
pushed a commit
to ne0h/openhab-addons
that referenced
this pull request
Sep 15, 2019
…hab#5273) * Added support for the Luxembourgian Smart Meter "Smarty" This is based on the DSMR protocol but with encrypted messages. Also some improvements to the thing defintion files for missing bridges and some small code improvements. * Updated readme. * Removed dependency on DatatypeConverter * Fixed SAT warnings. * Switched to units added to core. * Cleanup unit test. * Fix null warnings. Signed-off-by: Hilbrand Bouwkamp <[email protected]> Signed-off-by: Maximilian Hess <[email protected]>
Hilbrand
added
the
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on the DSMR protocol but with encrypted messages. Also some improvements to the thing definition files for missing bridges and some small code improvements.
This pr depends on openhab-core change openhab/openhab-core#695. That needs to be merged before this will build correctly.