Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed invalid day of week max check #1986

Merged
merged 1 commit into from
Dec 22, 2020
Merged

Fixed invalid day of week max check #1986

merged 1 commit into from
Dec 22, 2020

Conversation

Hilbrand
Copy link
Member

Closes #1813

@Hilbrand
Fix for invalid day of week max check
c33b037 
Closes openhab#1813

Signed-off-by: Hilbrand Bouwkamp <[email protected]>
@kaikreuzer kaikreuzer changed the title Fix for invalid day of week max check Fixed invalid day of week max check Dec 22, 2020
kaikreuzer
kaikreuzer approved these changes Dec 22, 2020
View reviewed changes
Copy link
Member

@kaikreuzer kaikreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@kaikreuzer kaikreuzer merged commit df20138 into openhab:master Dec 22, 2020
@kaikreuzer kaikreuzer added the bug An unexpected problem or unintended behavior of the Core label Dec 22, 2020
@kaikreuzer kaikreuzer added this to the 3.1 milestone Dec 22, 2020
@Hilbrand Hilbrand deleted the 1813 branch December 22, 2020 19:51
@cweitkamp cweitkamp mentioned this pull request Dec 24, 2020
Closed
@cweitkamp cweitkamp added the patch A PR that has been cherry-picked to a patch release branch label Jan 10, 2021
cweitkamp pushed a commit that referenced this pull request Jan 10, 2021
@Hilbrand @cweitkamp
Fix for invalid day of week max check (#1986)
cd30738 
Closes #1813

Signed-off-by: Hilbrand Bouwkamp <[email protected]>
@TBail TBail mentioned this pull request Dec 22, 2021
Closed
splatch pushed a commit to ConnectorIO/copybara-hab-core that referenced this pull request Jul 11, 2023
@Hilbrand @splatch
Fix for invalid day of week max check (openhab#1986)
68567bf 
Closes openhab#1813

Signed-off-by: Hilbrand Bouwkamp <[email protected]>
GitOrigin-RevId: df20138
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaikreuzer kaikreuzer kaikreuzer approved these changes

Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of the Core patch A PR that has been cherry-picked to a patch release branch
Projects
None yet
Milestone
3.1
Development

Successfully merging this pull request may close these issues.

"value too high" cron expression not accepted although expression is correct in OH2
3 participants
@Hilbrand @kaikreuzer @cweitkamp