Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"value too high" cron expression not accepted although expression is correct in OH2 #1813

Closed
mstormi opened this issue Nov 13, 2020 · 3 comments · Fixed by #1986
Closed

"value too high" cron expression not accepted although expression is correct in OH2 #1813

mstormi opened this issue Nov 13, 2020 · 3 comments · Fixed by #1986

Comments

@mstormi
Copy link

mstormi commented Nov 13, 2020 •
edited
Loading

using 3.0M3

I deployed a rule that was working fine under 2.5.10
Replacing "MON-SUN" with "*" fixes this so it's not critical but nonetheless this should be fixed in the cron code not in users' rules.

Related: #1516

2020-11-13 11:01:32.452 [ERROR] [ore.common.registry.AbstractRegistry] - Cannot inform the listener "org.openhab.core.automation.internal.RuleEngineImpl$2@1ae05dd" about the "ADDED" event: Value too high in range in cron expression '0 30 16 ? * MON-SUN' in field 'DayOfWeek': value 8, minimum: 7
java.lang.IllegalArgumentException: Value too high in range in cron expression '0 30 16 ? * MON-SUN' in field 'DayOfWeek': value 8, minimum: 7
@mstormi mstormi changed the title Cron expression not accepted "value too high" cron expression not accepted Nov 13, 2020
@mstormi mstormi changed the title "value too high" cron expression not accepted "value too high" cron expression not accepted although expression is correct in OH2 Nov 28, 2020
Hilbrand added a commit to Hilbrand/openhab-core that referenced this issue Dec 22, 2020
@Hilbrand
Fix for invalid day of week max check
c33b037 
Closes openhab#1813

Signed-off-by: Hilbrand Bouwkamp <[email protected]>
@Hilbrand Hilbrand mentioned this issue Dec 22, 2020
Merged
kaikreuzer pushed a commit that referenced this issue Dec 22, 2020
@Hilbrand
Fix for invalid day of week max check (#1986)
df20138 
Closes #1813

Signed-off-by: Hilbrand Bouwkamp <[email protected]>
@cweitkamp cweitkamp mentioned this issue Dec 24, 2020
Closed
@kaikreuzer kaikreuzer mentioned this issue Dec 29, 2020
Closed
@Besenreiter
Copy link

Hello,
I am using openHAB 3.0.0-1 (Release Build) but I still get when using SAT-SUN.
Is there anything I can do about it?
Thanks,
Ingo

@brainbug95
Copy link

@Besenreiter you could try and change "SAT-SUN" to "SAT,SUN" as a workaround.

@Besenreiter
Copy link

@Besenreiter you could try and change "SAT-SUN" to "SAT,SUN" as a workaround.

Thanks, I used the shnapshot, it's working

cweitkamp pushed a commit that referenced this issue Jan 10, 2021
@Hilbrand @cweitkamp
Fix for invalid day of week max check (#1986)
cd30738 
Closes #1813

Signed-off-by: Hilbrand Bouwkamp <[email protected]>
splatch pushed a commit to ConnectorIO/copybara-hab-core that referenced this issue Jul 11, 2023
@Hilbrand @splatch
Fix for invalid day of week max check (openhab#1986)
68567bf 
Closes openhab#1813

Signed-off-by: Hilbrand Bouwkamp <[email protected]>
GitOrigin-RevId: df20138
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed invalid day of week max check Hilbrand/openhab-core
3 participants
@mstormi @Besenreiter @brainbug95