Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Charts with transparent background #1183

Closed
mueller-ma opened this issue Nov 3, 2019 · 7 comments · Fixed by #2502
Closed

Charts with transparent background #1183

mueller-ma opened this issue Nov 3, 2019 · 7 comments · Fixed by #2502
Labels
UI User Interface

Comments

@mueller-ma
Copy link
Member

I'd like to see a chart theme with transparent background. Actually two themes with transparent background are needed: one for light and one for dark backgrounds.
Currently the grey background of the dark chart theme and the background of the android app aren't the same, which looks bad IMO.
@shutterfreak
Copy link

You may want to check with the new OH iOS repository as they found a way to recolor the charts for dark mode.

@mueller-ma
Copy link
Member Author

Well, the iOS app just appends the chart theme (https://github.com/openhab/openhab-ios/blob/master/openHAB/Endpoint.swift#L90).
This issue is about to add an additional chart theme.

@shutterfreak
Copy link

There’s more happening than switching the CSS theme. The charts are recoloured.

@mueller-ma
Copy link
Member Author

Can you point me to the code where the charts are recolored? Or post a screenshot? To me it seems that they just use the chart themes provided by the server.

@shutterfreak
Copy link

Here you go:
openhab/openhab-ios#468 (comment)

As you can see, the background is dark gray or black, and the reds are darker too.

@mueller-ma
Copy link
Member Author

This is just the basic chart theming...
Bright theme: http://demo.openhab.org:8080/chart?groups=Weather_Chart&period=h&theme=bright&t=1575145185130
Dark theme: http://demo.openhab.org:8080/chart?groups=Weather_Chart&period=h&theme=dark&t=1575145185130
Black theme: http://demo.openhab.org:8080/chart?groups=Weather_Chart&period=h&theme=black&t=1575145185130

@shutterfreak
Copy link

I didn't know this. Good to know.

@cweitkamp cweitkamp added the UI User Interface label Dec 15, 2019
mueller-ma added a commit to mueller-ma/openhab-core that referenced this issue Jun 25, 2021
@mueller-ma
Add chart theme with transparent background
81ce0f4 
Currently the background of the dark theme differs from the background
color of the Android app. With a transparent background, it'll be the
same.
The version bump is required so the app can use the current `dark` theme
for older versions of the server.

Closes openhab#1183
@mueller-ma mueller-ma mentioned this issue Jun 25, 2021
Closed
wborn added a commit to wborn/openhab-core that referenced this issue Oct 2, 2021
@wborn
ChartServlet bug fixes and improvements
b04758c 
* Improve exception handling
* Add dark_transparent theme
* Add null annotations
* Use java.time classes instead of Date and magic numbers
* Upgrade XChart to 3.1.0

For XChart release notes see:

https://knowm.org/open-source/xchart/xchart-change-log/

On newer XChart versions there is an issue when using customized grid lines:

knowm/XChart#628

Fixes openhab#1183
Related to openhab#2501
Supersedes openhab#2415

Signed-off-by: Wouter Born <[email protected]>
@wborn wborn mentioned this issue Oct 2, 2021
Merged
wborn added a commit to wborn/openhab-core that referenced this issue Oct 3, 2021
@wborn
ChartServlet bug fixes and improvements
9b678c4 
* Improve exception handling
* Add themes
* Add null annotations
* Use java.time classes instead of Date and magic numbers
* Upgrade XChart to 3.1.0

For XChart release notes see:

https://knowm.org/open-source/xchart/xchart-change-log/

On newer XChart versions there is an issue when using customized grid lines:

knowm/XChart#628

Fixes openhab#1183
Related to openhab#2501
Supersedes openhab#2415

Signed-off-by: Wouter Born <[email protected]>
wborn added a commit to wborn/openhab-core that referenced this issue Oct 3, 2021
@wborn
ChartServlet bug fixes and improvements
504e81a 
* Improve exception handling
* Add transparent themes
* Add null annotations
* Use java.time classes instead of Date and magic numbers
* Upgrade XChart to 3.1.0

For XChart release notes see:

https://knowm.org/open-source/xchart/xchart-change-log/

On newer XChart versions there is an issue when using customized grid lines:

knowm/XChart#628

Fixes openhab#1183
Related to openhab#2501
Supersedes openhab#2415

Signed-off-by: Wouter Born <[email protected]>
wborn added a commit to wborn/openhab-core that referenced this issue Oct 3, 2021
@wborn
ChartServlet bug fixes and improvements
21bf485 
* Improve exception handling
* Add transparent themes
* Add null annotations
* Use java.time classes instead of Date and magic numbers
* Upgrade XChart to 3.1.0
* Fix buggy legend position logic:
  Reinitialize counter to 0. So it does not work on legend position counter values of previously created charts.
  Use a local variable for the position counter instead of a field. This prevents issues when creating multiple charts simultanuously.

For XChart release notes see:

https://knowm.org/open-source/xchart/xchart-change-log/

On newer XChart versions there is an issue when using customized grid lines:

knowm/XChart#628

Fixes openhab#1183
Related to openhab#2501
Supersedes openhab#2415

Signed-off-by: Wouter Born <[email protected]>
wborn added a commit to wborn/openhab-core that referenced this issue Oct 4, 2021
@wborn
ChartServlet bug fixes and improvements
8fa2b1e 
* Improve exception handling
* Add transparent themes
* Add null annotations
* Use java.time classes instead of Date and magic numbers
* Upgrade XChart to 3.1.0
* Fix buggy legend position logic:
  Reinitialize counter to 0. So it does not work on legend position counter values of previously created charts.
  Use a local variable for the position counter instead of a field. This prevents issues when creating multiple charts simultanuously.

For XChart release notes see:

https://knowm.org/open-source/xchart/xchart-change-log/

On newer XChart versions there is an issue when using customized grid lines:

knowm/XChart#628

Fixes openhab#1183
Related to openhab#2501
Supersedes openhab#2415

Signed-off-by: Wouter Born <[email protected]>
wborn added a commit to wborn/openhab-core that referenced this issue Oct 4, 2021
@wborn
ChartServlet bug fixes and improvements
c0ad308 
* Improve exception handling
* Add transparent themes
* Add null annotations
* Use java.time classes instead of Date and magic numbers
* Upgrade XChart to 3.1.0
* Fix buggy legend position logic:
  Reinitialize counter to 0. So it does not work on legend position counter values of previously created charts.
  Use a local variable for the position counter instead of a field. This prevents issues when creating multiple charts simultanuously.

For XChart release notes see:

https://knowm.org/open-source/xchart/xchart-change-log/

On newer XChart versions there is an issue when using customized grid lines:

knowm/XChart#628

Fixes openhab#1183
Related to openhab#2501
Supersedes openhab#2415

Signed-off-by: Wouter Born <[email protected]>
wborn added a commit to wborn/openhab-core that referenced this issue Oct 4, 2021
@wborn
ChartServlet bug fixes and improvements
5638eda 
* Improve exception handling
* Add transparent themes
* Add null annotations
* Use java.time classes instead of Date and magic numbers
* Upgrade XChart to 3.1.0
* Fix buggy legend position logic:
  Reinitialize counter to 0. So it does not work on legend position counter values of previously created charts.
  Use a local variable for the position counter instead of a field. This prevents issues when creating multiple charts simultanuously.

For XChart release notes see:

https://knowm.org/open-source/xchart/xchart-change-log/

On newer XChart versions there is an issue when using customized grid lines:

knowm/XChart#628

Fixes openhab#1183
Related to openhab#2501
Supersedes openhab#2415

Signed-off-by: Wouter Born <[email protected]>
wborn added a commit to wborn/openhab-core that referenced this issue Oct 4, 2021
@wborn
ChartServlet bug fixes and improvements
4d951a5 
* Improve exception handling
* Add transparent themes
* Add null annotations
* Use java.time classes instead of Date and magic numbers
* Upgrade XChart to 3.1.0
* Fix buggy legend position logic:
  Reinitialize counter to 0. So it does not work on legend position counter values of previously created charts.
  Use a local variable for the position counter instead of a field. This prevents issues when creating multiple charts simultanuously.

For XChart release notes see:

https://knowm.org/open-source/xchart/xchart-change-log/

On newer XChart versions there is an issue when using customized grid lines:

knowm/XChart#628

Fixes openhab#1183
Related to openhab#2501
Supersedes openhab#2415

Signed-off-by: Wouter Born <[email protected]>
kaikreuzer pushed a commit that referenced this issue Oct 9, 2021
@wborn
ChartServlet bug fixes and improvements (#2502)
ac84206 
* Improve exception handling
* Add transparent themes
* Add null annotations
* Use java.time classes instead of Date and magic numbers
* Upgrade XChart to 3.1.0
* Fix buggy legend position logic:
  Reinitialize counter to 0. So it does not work on legend position counter values of previously created charts.
  Use a local variable for the position counter instead of a field. This prevents issues when creating multiple charts simultanuously.

For XChart release notes see:

https://knowm.org/open-source/xchart/xchart-change-log/

On newer XChart versions there is an issue when using customized grid lines:

knowm/XChart#628

Fixes #1183
Related to #2501
Supersedes #2415

Signed-off-by: Wouter Born <[email protected]>
@mueller-ma mueller-ma mentioned this issue Oct 10, 2021
Closed
splatch pushed a commit to ConnectorIO/copybara-hab-core that referenced this issue Jul 12, 2023
@wborn @splatch
ChartServlet bug fixes and improvements (openhab#2502)
7e5be2c 
* Improve exception handling
* Add transparent themes
* Add null annotations
* Use java.time classes instead of Date and magic numbers
* Upgrade XChart to 3.1.0
* Fix buggy legend position logic:
  Reinitialize counter to 0. So it does not work on legend position counter values of previously created charts.
  Use a local variable for the position counter instead of a field. This prevents issues when creating multiple charts simultanuously.

For XChart release notes see:

https://knowm.org/open-source/xchart/xchart-change-log/

On newer XChart versions there is an issue when using customized grid lines:

knowm/XChart#628

Fixes openhab#1183
Related to openhab#2501
Supersedes openhab#2415

Signed-off-by: Wouter Born <[email protected]>
GitOrigin-RevId: ac84206
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
UI User Interface
Projects
None yet
Milestone
No milestone
3 participants
@cweitkamp @mueller-ma @shutterfreak