Improve state generation logic when fetching icons #3456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Draft because I didn't test it yet. |
maniac103
force-pushed
the
icon-load-fixes
branch
from
603b543 to
3a8946e
Compare
If set, icon state should not be included when fetching the icon for a given widget. See openhab#3404 Signed-off-by: Danny Baumann <[email protected]>
See openhab#3404 Signed-off-by: Danny Baumann <[email protected]>
Signed-off-by: Danny Baumann <[email protected]>
BasicUI set a predecent for doing so, and users are relying on that behavior. Fixes openhab#3461 Signed-off-by: Danny Baumann <[email protected]>
maniac103
force-pushed
the
icon-load-fixes
branch
from
3a8946e to
84026b7
Compare
|
Gave it a try on my home sitemap, looks OK as far as I can tell. |
|
Thank you for your work |
|
@maniac103 Feel free to merge this. I don't have enough time to test this, but from a quick review it looks good to me. |
|
@mueller-ma OK. I guess/hope we'll get feedback from next beta if anything is off. |
|
@maniac103 @mueller-ma : regarding the state passed to the icon servlet, do you know if we are passing always the same state value in the Android app and Basic UI ? I hope we are consistent. |
|
I know that I don't know ;-) I would hope so, but I don't have a good idea on how to find out or even enforce it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for openhab/openhab-core#3735, format numeric state according to pattern (as mentioned here), and make logic a bit easier to understand.
Fixes #3404, #3461