Send NULL state as 'null' when requesting icons

BasicUI set a predecent for doing so, and users are relying on that behavior. Fixes #3461 Signed-off-by: Danny Baumann <[email protected]>
openhab · Aug 31, 2023 · 84026b7 · 84026b7
1 parent 9dfa34f
commit 84026b7
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/mobile/src/main/java/org/openhab/habdroid/model/IconResource.kt b/mobile/src/main/java/org/openhab/habdroid/model/IconResource.kt
@@ -137,7 +137,9 @@ internal fun String?.toOH2WidgetIconResource(
 
     val stateToUse = state ?: item?.state
     val iconState = when {
-        stateToUse == null || !useState || item == null -> null
+        !useState || item == null -> null
+        // For NULL states, we send 'null' as state when fetching the icon (BasicUI set a predecent for doing so)
+        stateToUse == null -> "null"
         // Number items need to use state formatted as per their state description
         item.isOfTypeOrGroupType(Item.Type.Number) || item.isOfTypeOrGroupType(Item.Type.NumberWithDimension)-> {
             stateToUse.asNumber.toString()