[miio] add support for nwt.derh.wdh318efw1 Internet Dehumidifier #9787
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,189 @@ | ||
| { | ||
| "deviceMapping": { | ||
| "id": [ | ||
| "nwt.derh.wdh318efw1" | ||
| ], | ||
| "channels": [ | ||
| { | ||
| "property": "on_off", | ||
| "friendlyName": "Power", | ||
| "channel": "power", | ||
| "type": "Switch", | ||
| "refresh": true, | ||
| "ChannelGroup": "Power", | ||
| "actions": [ | ||
| { | ||
| "command": "set_power", | ||
| "parameterType": "ONOFF" | ||
| } | ||
| ], | ||
| "category": "switch", | ||
| "tags": [ | ||
| "Switch" | ||
| ] | ||
| }, | ||
| { | ||
| "property": "mode", | ||
| "friendlyName": "Mode", | ||
| "channel": "mode", | ||
| "type": "String", | ||
| "refresh": true, | ||
| "ChannelGroup": "actions", | ||
| "actions": [ | ||
| { | ||
| "command": "set_mode", | ||
| "parameterType": "STRING" | ||
| } | ||
| ], | ||
| "tags": [ | ||
| "Control" | ||
| ] | ||
| }, | ||
| { | ||
| "property": "auto", | ||
| "friendlyName": "Auto humidity", | ||
| "channel": "autohumidity", | ||
| "type": "Number", | ||
| "refresh": true, | ||
| "ChannelGroup": "actions", | ||
| "actions": [ | ||
| { | ||
| "command": "set_auto", | ||
| "parameterType": "NUMBER" | ||
| } | ||
| ] | ||
| }, | ||
| { | ||
| "property": "fan_st", | ||
| "friendlyName": "Fan Speed", | ||
| "channel": "fanspeed", | ||
|
There was a problem hiding this comment. Huh, why do fan speed and fan status have opposite channel and property names? There was a problem hiding this comment. that must be an error. I fixed it |
||
| "type": "Number", | ||
| "refresh": true, | ||
| "ChannelGroup": "actions", | ||
| "actions": [ | ||
| { | ||
| "command": "set_fan_level", | ||
| "parameterType": "NUMBER" | ||
| } | ||
| ] | ||
| }, | ||
| { | ||
| "property": "buzzer", | ||
| "friendlyName": "Buzzer", | ||
| "channel": "buzzer", | ||
| "type": "Switch", | ||
| "refresh": true, | ||
| "ChannelGroup": "actions", | ||
| "actions": [ | ||
| { | ||
| "command": "set_buzzer", | ||
| "parameterType": "ONOFF" | ||
| } | ||
| ] | ||
| }, | ||
| { | ||
| "property": "led", | ||
| "friendlyName": "LED", | ||
| "channel": "led", | ||
| "type": "Switch", | ||
| "refresh": true, | ||
| "ChannelGroup": "actions", | ||
| "actions": [ | ||
| { | ||
| "command": "set_led", | ||
| "parameterType": "ONOFF" | ||
| } | ||
| ] | ||
| }, | ||
| { | ||
| "property": "child_lock", | ||
| "friendlyName": "Child Lock", | ||
| "channel": "childlock", | ||
| "type": "Switch", | ||
| "refresh": true, | ||
| "ChannelGroup": "actions", | ||
| "actions": [ | ||
| { | ||
| "command": "set_child_lock", | ||
| "parameterType": "ONOFF" | ||
| } | ||
| ] | ||
| }, | ||
| { | ||
| "property": "humidity", | ||
| "friendlyName": "Humidity", | ||
| "channel": "humidity", | ||
| "type": "Number:Dimensionless", | ||
| "unit": "PERCENT", | ||
| "refresh": true, | ||
| "ChannelGroup": "Status", | ||
| "actions": [], | ||
| "category": "humidity", | ||
| "tags": [ | ||
| "Measurement", | ||
| "Humidity" | ||
| ] | ||
| }, | ||
| { | ||
| "property": "temp", | ||
| "friendlyName": "Temperature", | ||
| "channel": "temperature", | ||
| "type": "Number:Temperature", | ||
| "unit": "CELCIUS", | ||
| "refresh": true, | ||
| "ChannelGroup": "Status", | ||
| "actions": [], | ||
| "category": "temperature", | ||
| "tags": [ | ||
| "Measurement", | ||
| "Temperature" | ||
| ] | ||
| }, | ||
| { | ||
| "property": "tank_full", | ||
| "friendlyName": "Tank Full", | ||
| "channel": "tankfull", | ||
| "type": "Switch", | ||
| "refresh": true, | ||
| "ChannelGroup": "Status", | ||
| "actions": [] | ||
| }, | ||
| { | ||
| "property": "compressor_status", | ||
| "friendlyName": "Compressor Status", | ||
| "channel": "compressorstatus", | ||
| "type": "Switch", | ||
| "refresh": true, | ||
| "ChannelGroup": "Status", | ||
| "actions": [] | ||
| }, | ||
| { | ||
| "property": "defrost_status", | ||
| "friendlyName": "Defrost Status", | ||
| "channel": "defroststatus", | ||
| "type": "Switch", | ||
| "refresh": true, | ||
| "ChannelGroup": "Status", | ||
| "actions": [] | ||
| }, | ||
| { | ||
| "property": "fan_speed", | ||
| "friendlyName": "Fan St", | ||
| "channel": "fanst", | ||
|
Comment on lines
+176
to
+177
There was a problem hiding this comment. Are these good friendly names for fan speed? There was a problem hiding this comment. @feodor85 What is the friedly name you see in the app UI for Fan St? any idea what it is. |
||
| "type": "Number", | ||
| "refresh": true, | ||
| "ChannelGroup": "Status", | ||
| "actions": [] | ||
| }, | ||
| { | ||
| "property": "alarm", | ||
| "friendlyName": "Alarm", | ||
| "channel": "alarm", | ||
| "type": "String", | ||
| "refresh": true, | ||
| "ChannelGroup": "Status", | ||
| "actions": [] | ||
| } | ||
| ] | ||
| } | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be a percentage?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@feodor85 can you comment on that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My file is completely working. If you have any comments, please send a new file and I'll test it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the question of @cpmeister is if this is a percentage in the app, as then the number is better presented as a quantityType Number:Dimensionless with unit: percentage.
It will work both ways, but the latter is more in line of OH3 semantic model line of thinking
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do i need to change to and check?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that is all that would need to change, but @marcelrv would have to confirm that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indeed 👍