Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[miio] add support for nwt.derh.wdh318efw1 Internet Dehumidifier #9787

Merged
merged 3 commits into from
Jan 18, 2021

Conversation

marcelrv
Copy link
Contributor

based on json provided & tested by @feodor85
closing #9737

Signed-off-by: Marcel Verpaalen [email protected]

based on json provided & tested by @feodor85
closing openhab#9737
Signed-off-by: Marcel Verpaalen <[email protected]>
@marcelrv marcelrv added the enhancement An enhancement or new feature for an existing add-on label Jan 11, 2021
@marcelrv marcelrv requested a review from cpmeister January 11, 2021 23:10
"property": "auto",
"friendlyName": "Auto humidity",
"channel": "autohumidity",
"type": "Number",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be a percentage?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@feodor85 can you comment on that

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My file is completely working. If you have any comments, please send a new file and I'll test it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the question of @cpmeister is if this is a percentage in the app, as then the number is better presented as a quantityType Number:Dimensionless with unit: percentage.

It will work both ways, but the latter is more in line of OH3 semantic model line of thinking

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do i need to change to and check?

"type": "Number:Dimensionless",
"unit": "PERCENT",

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that is all that would need to change, but @marcelrv would have to confirm that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indeed 👍

Signed-off-by: Marcel Verpaalen <[email protected]>
Comment on lines +172 to +173
"friendlyName": "Fan St",
"channel": "fanst",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these good friendly names for fan speed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@feodor85 What is the friedly name you see in the app UI for Fan St? any idea what it is.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fan Speed is OK

Comment on lines 58 to 60
"property": "fan_st",
"friendlyName": "Fan Speed",
"channel": "fanspeed",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, why do fan speed and fan status have opposite channel and property names?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that must be an error. I fixed it

Signed-off-by: Marcel Verpaalen <[email protected]>
@marcelrv marcelrv added rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels Jan 18, 2021
@cpmeister cpmeister merged commit 583d13e into openhab:main Jan 18, 2021
@cpmeister cpmeister added this to the 3.1 milestone Jan 18, 2021
@marcelrv marcelrv deleted the miio-nwt.derh.wdh318efw1 branch January 18, 2021 22:31
themillhousegroup pushed a commit to themillhousegroup/openhab2-addons that referenced this pull request May 10, 2021
…nhab#9787)

* [miio] add support for nwt.derh.wdh318efw1 Internet Dehumidifier

based on json provided & tested by @feodor85
closing openhab#9737

* [miio] change autohumidity
* [miio] fix switched property

Signed-off-by: Marcel Verpaalen <[email protected]>
Signed-off-by: John Marshall <[email protected]>
thinkingstone pushed a commit to thinkingstone/openhab-addons that referenced this pull request Nov 7, 2021
…nhab#9787)

* [miio] add support for nwt.derh.wdh318efw1 Internet Dehumidifier

based on json provided & tested by @feodor85
closing openhab#9737

* [miio] change autohumidity
* [miio] fix switched property

Signed-off-by: Marcel Verpaalen <[email protected]>
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
…nhab#9787)

* [miio] add support for nwt.derh.wdh318efw1 Internet Dehumidifier

based on json provided & tested by @feodor85
closing openhab#9737

* [miio] change autohumidity
* [miio] fix switched property

Signed-off-by: Marcel Verpaalen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants