-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[miio] add support for nwt.derh.wdh318efw1 Internet Dehumidifier #9787
Conversation
based on json provided & tested by @feodor85 closing openhab#9737 Signed-off-by: Marcel Verpaalen <[email protected]>
"property": "auto", | ||
"friendlyName": "Auto humidity", | ||
"channel": "autohumidity", | ||
"type": "Number", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be a percentage?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@feodor85 can you comment on that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My file is completely working. If you have any comments, please send a new file and I'll test it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the question of @cpmeister is if this is a percentage in the app, as then the number is better presented as a quantityType Number:Dimensionless with unit: percentage.
It will work both ways, but the latter is more in line of OH3 semantic model line of thinking
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do i need to change to and check?
"type": "Number:Dimensionless",
"unit": "PERCENT",
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that is all that would need to change, but @marcelrv would have to confirm that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indeed 👍
Signed-off-by: Marcel Verpaalen <[email protected]>
"friendlyName": "Fan St", | ||
"channel": "fanst", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these good friendly names for fan speed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@feodor85 What is the friedly name you see in the app UI for Fan St? any idea what it is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fan Speed is OK
"property": "fan_st", | ||
"friendlyName": "Fan Speed", | ||
"channel": "fanspeed", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huh, why do fan speed and fan status have opposite channel and property names?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that must be an error. I fixed it
Signed-off-by: Marcel Verpaalen <[email protected]>
…nhab#9787) * [miio] add support for nwt.derh.wdh318efw1 Internet Dehumidifier based on json provided & tested by @feodor85 closing openhab#9737 * [miio] change autohumidity * [miio] fix switched property Signed-off-by: Marcel Verpaalen <[email protected]> Signed-off-by: John Marshall <[email protected]>
…nhab#9787) * [miio] add support for nwt.derh.wdh318efw1 Internet Dehumidifier based on json provided & tested by @feodor85 closing openhab#9737 * [miio] change autohumidity * [miio] fix switched property Signed-off-by: Marcel Verpaalen <[email protected]>
…nhab#9787) * [miio] add support for nwt.derh.wdh318efw1 Internet Dehumidifier based on json provided & tested by @feodor85 closing openhab#9737 * [miio] change autohumidity * [miio] fix switched property Signed-off-by: Marcel Verpaalen <[email protected]>
based on json provided & tested by @feodor85
closing #9737
Signed-off-by: Marcel Verpaalen [email protected]