Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bluetooth.govee] Govee Bluetooth Binding initial contribution #8610
[bluetooth.govee] Govee Bluetooth Binding initial contribution #8610
Changes from 7 commits
9fddbb7
87176b9
8b431f4
b495c26
34dc14d
6b79f5d
6c61d99
28ce71b
d5060d0
5d9d53c
5a122ee
e07a1b1
5cd88ae
1778410
63ecb6d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You use "extension", "adapter" and "binding" for this code in different places.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is kinda the case for all of the bluetooth bindings...
"extension" refers to the fact that the binding adds functionality to the base bluetooth bindings.
"adapter" is used the pom.xml as part of the project name. But strictly speaking I don't really think this is appropriate and the word should probably be changed to
extension
instead. But this standard was in place for all of the other bluetooth bindings so if I'm going to change it it should be a separate PR.I do agree with you that these naming conventions are a bit confusing and I would love to change them at some point.