[bluetooth.govee] Govee Bluetooth Binding initial contribution #8610

cpmeister · 2020-09-30T00:05:33Z

I got some of these devices in order to try to test the new bluetooth dynamic channel generation feature I've been working on. Sadly they didn't really help, but since I already had the devices on my hands I made a quick binding for them anyway.

Signed-off-by: Connor Petty [email protected]

TravisBuddy · 2020-09-30T00:09:45Z

Travis tests were successful

Hey @cpmeister,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

cpmeister · 2020-09-30T00:13:47Z

If you consider this a test of the new binding generation script, it seems to have really botched the bundles/pom.xml file by adding blank lines everywhere.

bundles/org.openhab.binding.bluetooth.govee/README.md

...ee/src/main/java/org/openhab/binding/bluetooth/govee/internal/GoveeDiscoveryParticipant.java

bundles/org.openhab.binding.bluetooth.govee/src/main/resources/OH-INF/thing/thing-types.xml

Signed-off-by: Connor Petty <[email protected]>

cpmeister · 2020-11-28T05:19:10Z

So my initial implementation of this binding didn't actually work when I tested it, so I've had to rewrite it from scratch.
Been working and testing this for the past month and I can finally say this is ready for review.

Signed-off-by: Connor Petty <[email protected]>

bundles/org.openhab.binding.bluetooth.govee/README.md

fwolter · 2020-12-04T18:48:31Z

bundles/org.openhab.binding.bluetooth.govee/src/main/feature/feature.xml

+<features name="org.openhab.binding.bluetooth.govee-${project.version}" xmlns="http://karaf.apache.org/xmlns/features/v1.4.0">
+	<repository>mvn:org.openhab.core.features.karaf/org.openhab.core.features.karaf.openhab-core/${ohc.version}/xml/features</repository>
+
+	<feature name="openhab-binding-bluetooth-govee" description="Bluetooth Binding Govee" version="${project.version}">


You use "extension", "adapter" and "binding" for this code in different places.

That is kinda the case for all of the bluetooth bindings...
"extension" refers to the fact that the binding adds functionality to the base bluetooth bindings.
"adapter" is used the pom.xml as part of the project name. But strictly speaking I don't really think this is appropriate and the word should probably be changed to extension instead. But this standard was in place for all of the other bluetooth bindings so if I'm going to change it it should be a separate PR.

I do agree with you that these naming conventions are a bit confusing and I would love to change them at some point.

...ee/src/main/java/org/openhab/binding/bluetooth/govee/internal/ConnectedBluetoothHandler.java

bundles/org.openhab.binding.bluetooth.govee/src/main/resources/OH-INF/thing/thing-types.xml

fwolter · 2020-12-04T19:20:53Z

...c/test/java/org/openhab/binding/bluetooth/govee/internal/readme/ThingTypeTableGenerator.java

+ * @author Connor Petty - Initial contribution
+ *
+ */
+public class ThingTypeTableGenerator {


I like this. Love to see this at some more prominent location.

...govee/src/main/java/org/openhab/binding/bluetooth/govee/internal/GoveeHygrometerHandler.java

...rc/main/java/org/openhab/binding/bluetooth/govee/internal/command/hygrometer/GetCommand.java

...rc/main/java/org/openhab/binding/bluetooth/govee/internal/command/hygrometer/SetCommand.java

Signed-off-by: Connor Petty <[email protected]>

fwolter

LGTM

bluetooth.govee Signed-off-by: Connor Petty <[email protected]>

Signed-off-by: Connor Petty <[email protected]>

cpmeister · 2021-01-15T20:28:11Z

@openhab/add-ons-maintainers This needs a second reviewer if someone can take a look. Thanks.

Hilbrand

Just some small stuff.

bundles/org.openhab.binding.bluetooth.govee/src/main/feature/feature.xml

.../org/openhab/binding/bluetooth/govee/internal/command/hygrometer/GetOrSetHumCaliCommand.java

bundles/org.openhab.binding.bluetooth.govee/src/main/resources/OH-INF/thing/thing-types.xml

...c/test/java/org/openhab/binding/bluetooth/govee/internal/readme/ThingTypeTableGenerator.java

Signed-off-by: Connor Petty <[email protected]>

Hilbrand

LGTM

openhab#8610)" This reverts commit 239e33a.

…ab#8610) Signed-off-by: Connor Petty <[email protected]> Signed-off-by: John Marshall <[email protected]>

…ab#8610) Signed-off-by: Connor Petty <[email protected]>

cpmeister requested a review from a team as a code owner September 30, 2020 00:05

cpmeister added the new binding If someone has started to work on a binding. For a new binding PR. label Sep 30, 2020

fwolter requested changes Oct 9, 2020

View reviewed changes

cpmeister added the work in progress A PR that is not yet ready to be merged label Nov 3, 2020

Connor Petty added 2 commits November 27, 2020 13:17

Rebase against main branch

9fddbb7

Signed-off-by: Connor Petty <[email protected]>

Finish readme

87176b9

Signed-off-by: Connor Petty <[email protected]>

cpmeister force-pushed the bluetooth.govee branch from 9f70b88 to 87176b9 Compare November 28, 2020 04:52

cpmeister removed the work in progress A PR that is not yet ready to be merged label Nov 28, 2020

Connor Petty added 2 commits November 27, 2020 21:00

Fix stuff missed during rebase.

8b431f4

Signed-off-by: Connor Petty <[email protected]>

Really fix rebase mistake.

b495c26

Signed-off-by: Connor Petty <[email protected]>

code cleanup

34dc14d

Signed-off-by: Connor Petty <[email protected]>

cpmeister requested a review from fwolter December 4, 2020 18:27

fwolter requested changes Dec 4, 2020

View reviewed changes

Address review comments

6b79f5d

Signed-off-by: Connor Petty <[email protected]>

cpmeister requested review from cdjackson and kaikreuzer as code owners December 4, 2020 23:25

More readme adjustments

6c61d99

Signed-off-by: Connor Petty <[email protected]>

fwolter approved these changes Dec 6, 2020

View reviewed changes

fwolter added the cre Coordinated Review Effort label Dec 6, 2020

Connor Petty added 6 commits January 15, 2021 11:46

Merge branch 'main' of https://github.com/openhab/openhab-addons into

28ce71b

bluetooth.govee Signed-off-by: Connor Petty <[email protected]>

Fix unit changes.

d5060d0

Signed-off-by: Connor Petty <[email protected]>

Fix project version.

5d9d53c

Signed-off-by: Connor Petty <[email protected]>

Fix license header dates

5a122ee

Signed-off-by: Connor Petty <[email protected]>

Fix version override warning

e07a1b1

Signed-off-by: Connor Petty <[email protected]>

Fix author tag.

5cd88ae

Signed-off-by: Connor Petty <[email protected]>

wborn added the rebuild Triggers Jenkins PR build label Jan 22, 2021

wborn removed the rebuild Triggers Jenkins PR build label Jan 22, 2021

Hilbrand requested changes Jan 23, 2021

View reviewed changes

Address review comments

1778410

Signed-off-by: Connor Petty <[email protected]>

cpmeister requested a review from Hilbrand January 24, 2021 07:38

Properly label required parameters

63ecb6d

Signed-off-by: Connor Petty <[email protected]>

Hilbrand approved these changes Jan 24, 2021

View reviewed changes

Hilbrand merged commit 239e33a into openhab:main Jan 25, 2021

Hilbrand removed the cre Coordinated Review Effort label Jan 25, 2021

Hilbrand added this to the 3.1 milestone Jan 25, 2021

lsiepel added a commit to lsiepel/openhab-addons that referenced this pull request Feb 9, 2021

Revert "[bluetooth.govee] Govee Bluetooth Binding initial contribution (

e993d7d

openhab#8610)" This reverts commit 239e33a.

thinkingstone pushed a commit to thinkingstone/openhab-addons that referenced this pull request Nov 7, 2021

[bluetooth.govee] Govee Bluetooth Binding initial contribution (openh…

c2c1a1a

…ab#8610) Signed-off-by: Connor Petty <[email protected]>

marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022

[bluetooth.govee] Govee Bluetooth Binding initial contribution (openh…

31e8b69

…ab#8610) Signed-off-by: Connor Petty <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[bluetooth.govee] Govee Bluetooth Binding initial contribution #8610

[bluetooth.govee] Govee Bluetooth Binding initial contribution #8610

cpmeister commented Sep 30, 2020

TravisBuddy commented Sep 30, 2020 •

edited

Loading

cpmeister commented Sep 30, 2020

cpmeister commented Nov 28, 2020

fwolter Dec 4, 2020

cpmeister Dec 4, 2020 •

edited

Loading

fwolter Dec 4, 2020

fwolter left a comment

cpmeister commented Jan 15, 2021

Hilbrand left a comment

Hilbrand left a comment

[bluetooth.govee] Govee Bluetooth Binding initial contribution #8610

[bluetooth.govee] Govee Bluetooth Binding initial contribution #8610

Conversation

cpmeister commented Sep 30, 2020

TravisBuddy commented Sep 30, 2020 • edited Loading

Travis tests were successful

cpmeister commented Sep 30, 2020

cpmeister commented Nov 28, 2020

fwolter Dec 4, 2020

Choose a reason for hiding this comment

cpmeister Dec 4, 2020 • edited Loading

Choose a reason for hiding this comment

fwolter Dec 4, 2020

Choose a reason for hiding this comment

fwolter left a comment

Choose a reason for hiding this comment

cpmeister commented Jan 15, 2021

Hilbrand left a comment

Choose a reason for hiding this comment

Hilbrand left a comment

Choose a reason for hiding this comment

TravisBuddy commented Sep 30, 2020 •

edited

Loading

cpmeister Dec 4, 2020 •

edited

Loading