[modbus] Update README.md #8228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hoping I have added a Table of Contents to this large document. I am not at all familiar with this editor, and do not know if I have done this correctly! Signed-off-by Ross Kennedy <[email protected]>
Travis tests have failedHey @Rossko57, |
|
Sounds like a good idea! I am actually not familiar with the syntax. Would @Confectrician help here please? |
Small changes to 'length' and 'Discovery' descriptions.
ssalonen
added a commit
to ssalonen/openhab2-addons
that referenced
this pull request
Aug 30, 2020
Related to discussion in openhab#8228 Signed-off-by: Sami Salonen <[email protected]>
|
I tested the toc notation and it should work. It's also the same syntax used on other documentation pages. Does this change required other changes? |
Thankyou for that. It was just doubts on our part, not having used the ToC style before, as there seems to be no preview for the effect. |
"Generalized" the comment about poller length limits. I wasn't happy with it really, new parameter validation replaces much explanation :) Signed-off-by Ross Kennedy [email protected]
Hilbrand
pushed a commit
that referenced
this pull request
Sep 12, 2020
…ec (#8370) * Related to discussion in #8228 * Documented where the limits come from. * Internet is full of interpretation and variations. We follow the spec. Signed-off-by: Sami Salonen <[email protected]>
CSchlipp
pushed a commit
to CSchlipp/openhab-addons
that referenced
this pull request
Sep 12, 2020
…ec (openhab#8370) * Related to discussion in openhab#8228 * Documented where the limits come from. * Internet is full of interpretation and variations. We follow the spec. Signed-off-by: Sami Salonen <[email protected]>
|
@ssalonen Can you have another look? |
|
Lgtm |
Hilbrand
approved these changes
Sep 14, 2020
markus7017
pushed a commit
to markus7017/openhab-addons
that referenced
this pull request
Sep 19, 2020
…ec (openhab#8370) * Related to discussion in openhab#8228 * Documented where the limits come from. * Internet is full of interpretation and variations. We follow the spec. Signed-off-by: Sami Salonen <[email protected]>
markus7017
pushed a commit
to markus7017/openhab-addons
that referenced
this pull request
Sep 19, 2020
* Added a Table of Contents to this large document. * Small changes to 'length' and 'Discovery' descriptions. * "Generalized" the comment about poller length limits. I wasn't happy with it really, new parameter validation replaces much explanation :) Signed-off-by Ross Kennedy <[email protected]>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Oct 8, 2020
…ec (openhab#8370) * Related to discussion in openhab#8228 * Documented where the limits come from. * Internet is full of interpretation and variations. We follow the spec. Signed-off-by: Sami Salonen <[email protected]>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Oct 8, 2020
* Added a Table of Contents to this large document. * Small changes to 'length' and 'Discovery' descriptions. * "Generalized" the comment about poller length limits. I wasn't happy with it really, new parameter validation replaces much explanation :) Signed-off-by Ross Kennedy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hoping I have added a Table of Contents to this large document. I am not at all familiar with this editor, and do not know if I have done this correctly!
Signed-off-by Ross Kennedy [email protected]