Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hydrawise][WIP] Fixes #7261 #7265

Closed
wants to merge 2 commits into from

Conversation

digitaldan
Copy link
Contributor

Fixes a NPE due to a change in the Hydrawise API, adds additional controller statuses as a channels, improves documentation.

Signed-off-by: digitaldan [email protected]

Fixes a NPE due to a change in the Hydrawise API, adds additional controller statuses as a channles.

Signed-off-by: digitaldan <[email protected]>
@TravisBuddy
Copy link

Travis tests were successful

Hey @digitaldan,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

@cpmeister cpmeister added bug An unexpected problem or unintended behavior of an add-on rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels Apr 1, 2020
…ast contact time to UoM Time.

Signed-off-by: digitaldan <[email protected]>
@TravisBuddy
Copy link

Travis tests were successful

Hey @digitaldan,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

@digitaldan
Copy link
Contributor Author

Thanks @cpmeister for the review!

@digitaldan digitaldan changed the title [hydrawise] Fixes #7261 [hydrawise][WIP] Fixes #7261 Apr 2, 2020
@digitaldan
Copy link
Contributor Author

Hold off on this one, i am looking through the API responses more carefully and realized there are more changes than just the controller online status.

@cpmeister cpmeister added the enhancement An enhancement or new feature for an existing add-on label Apr 2, 2020
@cpmeister cpmeister linked an issue Apr 2, 2020 that may be closed by this pull request
@DenDeXTeR51
Copy link

  1. They changed API(last year's API was better…) As i understand some information now is only available via GraphQL & OAuth2.0 and limited data via REST.

URL for new api - https://support.hydrawise.com/hc/en-us/articles/360008965753-Hydrawise-API-Information

  1. Also they implement "refresh windows", now you cannot just update every 30 second. There is parameter in json (time for next request)

"Rate Limiting
Access to this API is rate limited. The statusschedule.php request has a field called nextpoll that indicates when the next API query should be made. Queries over this rate may be rejected with an HTTP 429 status code."

@digitaldan
Copy link
Contributor Author

Thanks @DenDeXTeR51 , I'm aware of the new version of the API. Unfortunately they removed a lot of the functionality i was using . I have a GraphQL version of the binding in development now, which is what they use for their own clients and new integrations. It will allow the binding to retain its current functionally as well as get some new features. I'll post back here when i have a version ready for testing.

@digitaldan
Copy link
Contributor Author

Closing this in favor of a new PR based on their GraphQL APi

@digitaldan digitaldan closed this May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[hydrawise] Stuck in Initializing phase
4 participants