-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[hydrawise] Stuck in Initializing phase #7261
Comments
I have found the error in the log it only appears when I restart the bundle
It looks to me that customerdetails gives back the info but some items are not in the expected format might be status. Here is my response from API ( https://app.hydrawise.com/api/v1/customerdetails.php?api_key=myAPIKey&type=controllers) )
|
Hi, thanks for the report and the sample response, that helps confirm the issue. I have noticed too, it looks like they slightly changed the api, i have a fix i have been testing locally, but totally forgot to get this committed. I'll do that soon. |
Fixes a NPE due to a change in the Hydrawise API, adds additional controller statuses as a channles. Signed-off-by: digitaldan <[email protected]>
Hi!
URL for new api - https://support.hydrawise.com/hc/en-us/articles/360008965753-Hydrawise-API-Information
"Rate Limiting |
I can confirm that this error persists.
|
I will no longer be using the API listed above, they ended up removing quite a bit of functionality. I have a working version based on their GraphQL api, which is what the mobile and web clients use. There will be some changes to how you long in, the API key will no longer be used, instead you will enter your user name and password, and the binding will retrieve a OAuth access and refresh token to log in with, it will then delete your password so we do not need to store that beyond the first login. The other change will be the thing structure will now include an "account" bridge, so items will have a different structure which will include the bridge type , but channels will remain the same, so hopefully this will be a search and replace operation to migrate Normally i would try to maintain backwards compatibility, but my guess is there are less than a dozen people using the binding, so i think now is the right time to make clean break and do this the right way. |
Update: I have a version of this working against the new API, I just need to clean up a few things and update documentation. I'm hoping to have a test version today or tomorrow if anyone wants to help test it. |
Hi Dan,
I can help to test
P.
…On Tue, May 5, 2020 at 3:50 PM Dan Cunningham ***@***.***> wrote:
Update: I have a version of this working against the new API, I just need
to clean up a few things and update documentation. I'm hoping to have a
test version today or tomorrow if anyone wants to help test it.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#7261 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AO74KIZTLCHHPUSRWDE3753RQAKS3ANCNFSM4LXLQ6JQ>
.
|
Hi Dan, Chris |
Hi!
I сan help to test!
Denys K.
… 5 мая 2020 г., в 16:50, Dan Cunningham ***@***.***> написал(а):
Update: I have a version of this working against the new API, I just need to clean up a few things and update documentation. I'm hoping to have a test version today or tomorrow if anyone wants to help test it.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub <#7261 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ANOHPX67AIMZJPSBUS5I5HDRQAKS3ANCNFSM4LXLQ6JQ>.
|
HI @digitaldan, would also be happy to help testing! Best, |
Hi guys, i have a new jar at I crudely updated the readme with the new "Account bridge" section, see I still have a bunch of clean up work todo and testing, not to mention documentation, but the binding seems to be working and stable. I'm listing detailed install instructions, but the short version is you will
For this new binding you will want to delete your cloud controller thing FIRST, then uninstall the current binding. Then install this new Jar (drop into your addons folder, or use the karaf console to install) Once installed, in the PaperUI under the "Things" section add a new thing: Then select the Hydrawise binding: Then select "Add Manually" and select "Account Thing" In the next screen, name the account thing, in the readme i use "myaccount" , but name it anything you want: also enter your account username and password. The password will only be retained while the binding attempts to connect, unless the option to save it is enabled. One a successful connection is made we store an oAuth token for future use. Your Inbox should now have your controller listed, or multiple controllers if you have more then one on your account. Go ahead and add it. Take a look at its ID (also shown under its channels). You will need it to update your items file below. To use existing items you have in a file , it's a simple find and replace job. For example:
becomes
where 123456 is the id of the controller (look in the paperUI) and "myaccount" is whatever you name your account thing. All i did was find |
Hi @digitaldan, I've got two different systems; Edit 1 (TEST/LIVE): openhab.log of TEST:
Edit 2 (TEST): Edit 3 (LIVE): openhab.log of LIVE:
Edit 4 (LIVE): According to KARAF, the Hydrawise-binding is running; Edit 5 (LIVE): Edit 6 (LIVE): First off, the inbox log; After adding from inbox;
|
Thanks @giterest ! i'll take a look. Your last error is strange, its breaking on trying to parse the time string for the weather forecast, what is strange is that it works on my system, the only difference is that my offset is -7 where yours is +2 , I'll try and reproduce that today. The other errors look like they stem from an issue with handling the passcode? possibly b/c a symbol in it ? Let me see if i need to be escaping that string before sending to the http client, although we should never be allowing a null pointer error, so that is also a bug. |
Hi @digitaldan ! So initial feedback: works well! Will start now to integrate it more into my home automation setup (all zones, ...) and let you know once I have additional feedback. Once again, so thankful for you work! David |
First addition:
Further I tested some of the channels, e.g. Zone #summary and Zone #nextruntime and did not receive any feedback for "summary" and only got feedback once for nextruntime, but then the information was gone and did not reload. |
@dgebhardt is the refresh time still 60 seconds or did you set it to a lower value ? I'm wondering if you are being rate limited by the service. |
Nm, i can see its still 60 seconds |
@digitaldan it's still 60s. But I am not sure, if it's contradicted by the fact, that I am adding new items/ sitemap entries and save that back to openHAB and then openHAB is trying to query the information from Hydrawise? (so probably more often than every 60s)? |
maybe, although i have seen this as well, but far less frequently , doing a little googling shows there might be a bug in the Jetty client with certain SSL servers, i will investigate, let me know if the problem gets better, worse or stays the same. |
I'll take a look, i have not actually tested those yet :-) |
@digitaldan Thanks! Regarding the channels: Tested and working: Tested and not working: I could not test sensor related stuff, as I don't have any. |
Will stop working on items/ sitemaps for a while and monitor the logs for a bit and let you know. |
@digitaldan in regards to the timezone - yes, realls strange as it shouldn't make any difference parsing these. the fault symbol was a "^" - independent on the password length, so yes - I guess if you're escaping any special chars it should work. What I can't reproduce is what @dgebhardt is reporting - I've got a stable (account) thing connection with not a single status change since my initial comment on this issue. Can't test any more stuff until I can get my controller working. |
I gave it another try (because.. you never know) with adding the controller thing, but same error is popping up again;
@dgebhardt - do you have any other offset than +2 like me? |
its strange, i just tried hardcoding your time stamp in the code and it parses it correctly:
|
@giterest i just made a small change, can you download the jar again and try it out? |
Thanks! |
hi @digitaldan - as the JAR running smoothly for months now, is there already a PR? |
Sorry for letting this rot for so long. I have an updated version of this jar for OH3 at https://github.com/digitaldan/openhab-addons/releases/tag/3.x , its about time i get this over the line! |
Hi @digitaldan , Log: |
Yeah, there was a Karaf upgrade , openhab/openhab-core#2264 that will require addons to be compiled against the new dependencies , I'll post an updated jar as soon as I'm back at my computer . |
New jar has been updated against the latest upstream changes |
Thanks! I downloaded it, removed the old one, rebooted OH, installed the new JAR, but there is a (new) error in the log:
|
oof, sorry , i realized i misread your stack trace, this version will only work against the nightly builds, which i would not recommend just yet (there is a cloud connector issue i'm working on right now) , let me see if i can build against a previous version. Are you on a milestone release , if so which one? |
thanks for your fast answer. |
Hello @digitaldan thanks a lot for this binding. I too am on OH3.1M3. Where should I get the hydrawise add-on build that goes with it, please? |
|
Yes, thanks. I tried that one, and I get the same error as HarriPinter above, and thought this would apply as well:
|
same here, I do have still the error message described above :-) |
Hi sorry, I was having trouble building for the last milestone release, my build can't find the dependencies needed as they are probably no longer in our artifact repo. The binding i have posted works only with the nightlies right now due to the karaf change, but will work with the next milestone release. I'm not sure when that will be, but we are probably due for another release soon! |
Actually, i was able to build against 3.0.3, can you try that one, its at the same location: |
I tried the 3.0.3 and it is working again!
Yeah, I can water my garden again with OpenHAB! |
Ah, yes, after trying once more, I was able to get the 3.0.3 jar file in and to get to an online hydrawise bridge on my OH3.1.M3 setup:-) So that is good, thank you @digitaldan and @HarriPinter. But, when I create a controller thing, i get a bunch of java error as follows: Thanks in advance for any help. |
Ok, never mind, I restarted OH and it seems to be working:-) Thank you very much guys. I look forward using this. |
Hi @digitaldan, sorry bothering you again... :-)
I tried the older org.openhab.binding.hydrawise-3.1.0-SNAPSHOT.jar as well - but got that error too:
Could you please have a look? :-) It is getting warm outside and we need to water the garden. LOL :-) |
I just want to confirm that the latest release from you, @digitaldan, is working fine with OH3.1 release. May I ask, if there plans that this binding will be a part of future OH-releases? |
Fixes openhab#7261 Signed-off-by: Dan Cunningham <[email protected]>
I finally submitted a PR for this , so hopefully it gets approved and merged soon. |
* [hydrawise] Migrated to new GraphQL based API Fixes #7261 Signed-off-by: Dan Cunningham <[email protected]> * Addressed PR comments. Signed-off-by: Dan Cunningham <[email protected]> * Address PR review comments. Signed-off-by: Dan Cunningham <[email protected]>
* [hydrawise] Migrated to new GraphQL based API Fixes openhab#7261 Signed-off-by: Dan Cunningham <[email protected]> * Addressed PR comments. Signed-off-by: Dan Cunningham <[email protected]> * Address PR review comments. Signed-off-by: Dan Cunningham <[email protected]>
* [hydrawise] Migrated to new GraphQL based API Fixes openhab#7261 Signed-off-by: Dan Cunningham <[email protected]> * Addressed PR comments. Signed-off-by: Dan Cunningham <[email protected]> * Address PR review comments. Signed-off-by: Dan Cunningham <[email protected]>
* [hydrawise] Migrated to new GraphQL based API Fixes openhab#7261 Signed-off-by: Dan Cunningham <[email protected]> * Addressed PR comments. Signed-off-by: Dan Cunningham <[email protected]> * Address PR review comments. Signed-off-by: Dan Cunningham <[email protected]> Signed-off-by: Dave J Schoepel <[email protected]>
* [hydrawise] Migrated to new GraphQL based API Fixes openhab#7261 Signed-off-by: Dan Cunningham <[email protected]> * Addressed PR comments. Signed-off-by: Dan Cunningham <[email protected]> * Address PR review comments. Signed-off-by: Dan Cunningham <[email protected]>
HI, I have openHAB 2.5 on Raspbian, my hydrawise binding added successfully, however when I add a Thing HydraWise Cloud it stucks in Initializing status. I have checked the API key and it works, nothing shows up in the logs
The text was updated successfully, but these errors were encountered: