Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hue] Lamp handler exposes min/max Colour Temperature in state description #17637

Merged
merged 4 commits into from
Oct 28, 2024

Conversation

andrewfg
Copy link
Contributor

@andrewfg andrewfg commented Oct 27, 2024

Dynamically provide min/max values in the color temperature absolute channel's state description.

See discussion in openhab/openhab-core#3891

Signed-off-by: AndrewFG [email protected]

@andrewfg andrewfg added enhancement An enhancement or new feature for an existing add-on awaiting other PR Depends on another PR labels Oct 27, 2024
@andrewfg andrewfg requested a review from lolodomo October 27, 2024 10:42
@andrewfg andrewfg self-assigned this Oct 27, 2024
@andrewfg andrewfg requested a review from cweitkamp as a code owner October 27, 2024 10:42
@andrewfg andrewfg changed the title [hue] dynamically provide min/max values in color temperature channel's state description [hue] Dynamically provide min/max values in color temperature channel's state description Oct 27, 2024
@lolodomo
Copy link
Contributor

Depends on openhab/openhab-core#4420
Depends on openhab/openhab-core#4429

I don't think there is a real dependency with these 2 core PRs ?
I mean we can merge your improvement even without these core PRs.

@andrewfg andrewfg changed the title [hue] Dynamically provide min/max values in color temperature channel's state description [hue] Lamp handler exposes min/max Colour Temperature in state description Oct 28, 2024
@andrewfg andrewfg removed the awaiting other PR Depends on another PR label Oct 28, 2024
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@lolodomo lolodomo merged commit 67bb354 into openhab:main Oct 28, 2024
5 checks passed
@lolodomo lolodomo added this to the 4.3 milestone Oct 28, 2024
@andrewfg andrewfg deleted the hue-color-temp-min-max branch November 6, 2024 15:45
KaaNee pushed a commit to KaaNee/openhab-addons that referenced this pull request Nov 8, 2024
…ption (openhab#17637)

* [hue] provide color temperature min/max values dynamically in state description

Signed-off-by: AndrewFG <[email protected]>
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Dec 16, 2024
…ption (openhab#17637)

* [hue] provide color temperature min/max values dynamically in state description

Signed-off-by: AndrewFG <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants