-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[hue] Lamp handler exposes min/max Colour Temperature in state description #17637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…escription Signed-off-by: AndrewFG <[email protected]>
andrewfg
added
enhancement
An enhancement or new feature for an existing add-on
awaiting other PR
Depends on another PR
labels
Oct 27, 2024
6 tasks
andrewfg
changed the title
[hue] dynamically provide min/max values in color temperature channel's state description
[hue] Dynamically provide min/max values in color temperature channel's state description
Oct 27, 2024
12 tasks
Signed-off-by: AndrewFG <[email protected]>
lolodomo
reviewed
Oct 27, 2024
...ue/src/main/java/org/openhab/binding/hue/internal/handler/Clip2StateDescriptionProvider.java
Outdated
Show resolved
Hide resolved
...ab.binding.hue/src/main/java/org/openhab/binding/hue/internal/handler/Clip2ThingHandler.java
Show resolved
Hide resolved
I don't think there is a real dependency with these 2 core PRs ? |
Signed-off-by: AndrewFG <[email protected]>
andrewfg
changed the title
[hue] Dynamically provide min/max values in color temperature channel's state description
[hue] Lamp handler exposes min/max Colour Temperature in state description
Oct 28, 2024
lolodomo
approved these changes
Oct 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you
KaaNee
pushed a commit
to KaaNee/openhab-addons
that referenced
this pull request
Nov 8, 2024
…ption (openhab#17637) * [hue] provide color temperature min/max values dynamically in state description Signed-off-by: AndrewFG <[email protected]>
matchews
pushed a commit
to matchews/openhab-addons
that referenced
this pull request
Dec 16, 2024
…ption (openhab#17637) * [hue] provide color temperature min/max values dynamically in state description Signed-off-by: AndrewFG <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dynamically provide min/max values in the color temperature absolute channel's state description.
See discussion in openhab/openhab-core#3891
Signed-off-by: AndrewFG [email protected]