Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sitemap] Add new element Colortemperaturepicker #4420

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

lolodomo
Copy link
Contributor

Related to #3891

@lolodomo lolodomo requested a review from a team as a code owner October 22, 2024 19:03
@lolodomo lolodomo force-pushed the color_temperature_picker branch 2 times, most recently from a594720 to 20a5289 Compare October 23, 2024 21:38
@lolodomo
Copy link
Contributor Author

@openhab/core-maintainers : please review & merge this small PR (42 new lines). I would like to give enough time to iOS and Android app to support this new widget before OH 4.3 is released.

Copy link
Member

@holgerfriedrich holgerfriedrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@holgerfriedrich holgerfriedrich merged commit 7d98903 into openhab:main Oct 29, 2024
5 checks passed
@holgerfriedrich holgerfriedrich added the enhancement An enhancement or new feature of the Core label Oct 29, 2024
@holgerfriedrich holgerfriedrich added this to the 4.3 milestone Oct 29, 2024
@lolodomo lolodomo deleted the color_temperature_picker branch October 29, 2024 06:37
@lolodomo
Copy link
Contributor Author

Thank you @holgerfriedrich

florian-h05 pushed a commit to openhab/openhab-webui that referenced this pull request Nov 30, 2024
Closes #2852.

Refs openhab/openhab-core#4420.
Related to openhab/openhab-core#3891.

This implements configuring a color temperature picker in the sitemap builder UI.

It also does some visualisation improvements of names and labels (by
defaults shows item label in treeview, analogous to model treeview).

---------

Also-by: Florian Hotze <[email protected]>
Signed-off-by: Mark Herwege <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature of the Core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants