Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[haywardomnilogic] Fix chlorinator bug #16820

Merged
merged 2 commits into from
May 31, 2024
Merged

Conversation

matchews
Copy link
Contributor

@matchews matchews commented May 28, 2024

Fixed a bug that causes the chlorinator to turn off if the salt output % channel is adjusted. Also added colorLogicLight speed and brightness channels to README.MD.

Regression from #15478

matchews added 2 commits May 28, 2024 16:13
… if the chlorinator salt % output channel was adjusted.

Signed-off-by: Matt Myers <[email protected]>
@matchews matchews added the bug An unexpected problem or unintended behavior of an add-on label May 28, 2024
@matchews matchews requested a review from lsiepel May 28, 2024 20:52
@lsiepel lsiepel added the regression Regression that happened during the development of a release. Not shown on final release notes. label May 28, 2024
@lsiepel lsiepel changed the title [haywardomnilogic] Fixed cholorinator bug created in PR#15478 [haywardomnilogic] Fixed chlorinator bug May 28, 2024
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@lsiepel lsiepel merged commit 2bfba0a into openhab:main May 31, 2024
5 checks passed
@lsiepel lsiepel changed the title [haywardomnilogic] Fixed chlorinator bug [haywardomnilogic] Fix chlorinator bug May 31, 2024
@lsiepel lsiepel added this to the 4.2 milestone May 31, 2024
stargazer74 pushed a commit to stargazer74/openhab-addons that referenced this pull request May 31, 2024
* Fixed chlorinator handler bug that caused the chlorinator to turn off if the chlorinator salt % output channel was adjusted.

Signed-off-by: Matt Myers <[email protected]>
Signed-off-by: Chris Wohlbrecht <[email protected]>
psmedley pushed a commit to psmedley/openhab-addons that referenced this pull request Jun 15, 2024
* Fixed chlorinator handler bug that caused the chlorinator to turn off if the chlorinator salt % output channel was adjusted.

Signed-off-by: Matt Myers <[email protected]>
Signed-off-by: Paul Smedley <[email protected]>
pgfeller pushed a commit to pgfeller/openhab-addons that referenced this pull request Sep 29, 2024
* Fixed chlorinator handler bug that caused the chlorinator to turn off if the chlorinator salt % output channel was adjusted.

Signed-off-by: Matt Myers <[email protected]>
Signed-off-by: Patrik Gfeller <[email protected]>
joni1993 pushed a commit to joni1993/openhab-addons that referenced this pull request Oct 15, 2024
* Fixed chlorinator handler bug that caused the chlorinator to turn off if the chlorinator salt % output channel was adjusted.

Signed-off-by: Matt Myers <[email protected]>
matchews added a commit to matchews/openhab-addons that referenced this pull request Oct 18, 2024
* Fixed chlorinator handler bug that caused the chlorinator to turn off if the chlorinator salt % output channel was adjusted.

Signed-off-by: Matt Myers <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on regression Regression that happened during the development of a release. Not shown on final release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants