-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[haywardomnilogic] Fix chlorinator bug #16820
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… if the chlorinator salt % output channel was adjusted. Signed-off-by: Matt Myers <[email protected]>
Signed-off-by: Matt Myers <[email protected]>
lsiepel
added
the
regression
Regression that happened during the development of a release. Not shown on final release notes.
label
May 28, 2024
lsiepel
changed the title
[haywardomnilogic] Fixed cholorinator bug created in PR#15478
[haywardomnilogic] Fixed chlorinator bug
May 28, 2024
lsiepel
approved these changes
May 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM
lsiepel
changed the title
[haywardomnilogic] Fixed chlorinator bug
[haywardomnilogic] Fix chlorinator bug
May 31, 2024
stargazer74
pushed a commit
to stargazer74/openhab-addons
that referenced
this pull request
May 31, 2024
* Fixed chlorinator handler bug that caused the chlorinator to turn off if the chlorinator salt % output channel was adjusted. Signed-off-by: Matt Myers <[email protected]> Signed-off-by: Chris Wohlbrecht <[email protected]>
psmedley
pushed a commit
to psmedley/openhab-addons
that referenced
this pull request
Jun 15, 2024
* Fixed chlorinator handler bug that caused the chlorinator to turn off if the chlorinator salt % output channel was adjusted. Signed-off-by: Matt Myers <[email protected]> Signed-off-by: Paul Smedley <[email protected]>
pgfeller
pushed a commit
to pgfeller/openhab-addons
that referenced
this pull request
Sep 29, 2024
* Fixed chlorinator handler bug that caused the chlorinator to turn off if the chlorinator salt % output channel was adjusted. Signed-off-by: Matt Myers <[email protected]> Signed-off-by: Patrik Gfeller <[email protected]>
joni1993
pushed a commit
to joni1993/openhab-addons
that referenced
this pull request
Oct 15, 2024
* Fixed chlorinator handler bug that caused the chlorinator to turn off if the chlorinator salt % output channel was adjusted. Signed-off-by: Matt Myers <[email protected]>
matchews
added a commit
to matchews/openhab-addons
that referenced
this pull request
Oct 18, 2024
* Fixed chlorinator handler bug that caused the chlorinator to turn off if the chlorinator salt % output channel was adjusted. Signed-off-by: Matt Myers <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
An unexpected problem or unintended behavior of an add-on
regression
Regression that happened during the development of a release. Not shown on final release notes.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a bug that causes the chlorinator to turn off if the salt output % channel is adjusted. Also added colorLogicLight speed and brightness channels to README.MD.
Regression from #15478