[haywardomnilogic] Add support for ColorLogic V2 Lights, Update Chlor Enable, Alert, Error, Status #15478

matchews · 2023-08-22T11:49:27Z

Added support for ColorLogic V2 Lights (Speed & Brightness)
Updated Chlor Enable based on updated Hayward API
Updated Chlor Alert, Error & Status to be string bit arrays based on new API intel
Updated miscellaneous units and patterns
Updated getTelemetry poll time based on Hayward API recommendations

https://community.openhab.org/t/hayward-omnilogic-pool-automation-binding/104105/119?u=matchews

openhab-bot · 2023-08-23T14:03:35Z

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/hayward-omnilogic-pool-automation-binding/104105/119

.../src/main/java/org/openhab/binding/haywardomnilogic/internal/handler/HaywardPumpHandler.java

lolodomo · 2023-10-18T06:31:19Z

Please note there is a file conflict to resolve.

matchews · 2023-10-27T20:39:34Z

Please note there is a file conflict to resolve.

Resolved.

lolodomo

Partial review

bundles/org.openhab.binding.haywardomnilogic/README.md

...in/java/org/openhab/binding/haywardomnilogic/internal/discovery/HaywardDiscoveryService.java

bundles/org.openhab.binding.haywardomnilogic/src/main/resources/OH-INF/thing/pump.xml

matchews · 2023-11-21T20:26:35Z

My apologies for having all changes in a single commit. My local repo blew up.

matchews · 2023-12-23T15:29:22Z

Anyone available to review this?

lsiepel · 2024-02-25T13:28:13Z

@lolodomo would you be able to proceed with the review? If you are too busy, i can spend some time on this if needed.

lsiepel

Some comments to fix. Mosty looks good, did you test the upgrade instructions? That is the last requirement i think before it can be merged.

bundles/org.openhab.binding.haywardomnilogic/README.md

...ain/java/org/openhab/binding/haywardomnilogic/internal/handler/HaywardColorLogicHandler.java

...les/org.openhab.binding.haywardomnilogic/src/main/resources/OH-INF/update/instructionsV1.xml

Signed-off-by: Matt Myers <[email protected]>

…dditional Shows) Signed-off-by: Matt Myers <[email protected]>

Signed-off-by: Matt Myers <[email protected]>

…rays based on updated Hayward API Signed-off-by: Matt Myers <[email protected]>

… values Signed-off-by: Matt Myers <[email protected]>

Signed-off-by: Matt Myers <[email protected]>

matchews · 2024-04-09T21:29:28Z

Some comments to fix. Mosty looks good, did you test the upgrade instructions? That is the last requirement i think before it can be merged.

Good catch! I tested (and fixed) the upgrade instructions. Is the breaking change alert no longer needed?

lsiepel

Left some comments and re-opened an earlier one to look into.

bundles/org.openhab.binding.haywardomnilogic/src/main/resources/OH-INF/thing/colorlogic.xml

bundles/org.openhab.binding.haywardomnilogic/src/main/resources/OH-INF/thing/chlorinator.xml

lsiepel

Thanks, LGTM

matchews · 2024-05-09T23:53:47Z

#16733/ From: lsiepel ***@***.***> Sent: Thursday, May 9, 2024 7:09 AM To: openhab/openhab-addons ***@***.***> Cc: Matt ***@***.***>; State change ***@***.***> Subject: Re: [openhab/openhab-addons] [haywardomnilogic] Add support for ColorLogic V2 Lights, Update Chlor Enable, Alert, Error, Status (PR #15478) @lsiepel commented on this pull request.

_____ In bundles/org.openhab.binding.haywardomnilogic/src/main/resources/OH-INF/thing/chlorinator.xml <#15478 (comment)> :

@@ -51,7 +50,7 @@

<item-type>Number:Dimensionless</item-type> <label>Salt Output (%)</label> <description>Current salt output setting for the chlorinator (%).</description> - <state min="0" max="100" step="1.0" pattern="%d %unit%" readOnly="false"/> + <state min="0" max="100" step="1.0" pattern="%d %" readOnly="false"/> Ah, sorry i missed this open comment and allready merged it. If you can create a follow up PR with this fix i can merge it really soon. — Reply to this email directly, view it on GitHub <#15478 (comment)> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACQXZPSZBSOE2FZWFCQGPULZBNKK5AVCNFSM6AAAAAA3ZZGYSSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDANBXG4YTMNBSGM> . You are receiving this because you modified the open/close state. <https://github.com/notifications/beacon/ACQXZPWPTJ4TWKBUBBJZS7LZBNKK5A5CNFSM6AAAAAA3ZZGYSSWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTT2BWWEO.gif> Message ID: ***@***.*** ***@***.***> >

…

-- This email has been checked for viruses by AVG antivirus software. www.avg.com

lsiepel · 2024-05-10T17:00:42Z

Some comments to fix. Mosty looks good, did you test the upgrade instructions? That is the last requirement i think before it can be merged.

Good catch! I tested (and fixed) the upgrade instructions. Is the breaking change alert no longer needed?

I don't see any breaking changes that should be mentioned. The thing upgrade instructions should do it's work.

…Enable, Alert, Error, Status (openhab#15478) * Update polling times based on Hayward API recommendations --------- Signed-off-by: Matt Myers <[email protected]>

…Enable, Alert, Error, Status (openhab#15478) * Update polling times based on Hayward API recommendations --------- Signed-off-by: Matt Myers <[email protected]> Signed-off-by: Paul Smedley <[email protected]>

…Enable, Alert, Error, Status (openhab#15478) * Update polling times based on Hayward API recommendations --------- Signed-off-by: Matt Myers <[email protected]> Signed-off-by: Patrik Gfeller <[email protected]>

…Enable, Alert, Error, Status (openhab#15478) * Update polling times based on Hayward API recommendations --------- Signed-off-by: Matt Myers <[email protected]>

matchews added the enhancement An enhancement or new feature for an existing add-on label Aug 22, 2023

matchews requested review from Hilbrand, fwolter, wborn and jlaur August 22, 2023 11:50

jlaur reviewed Aug 27, 2023

View reviewed changes

.../src/main/java/org/openhab/binding/haywardomnilogic/internal/handler/HaywardPumpHandler.java Outdated Show resolved Hide resolved

matchews force-pushed the haywardomnilogic branch from d1f7450 to 26711bb Compare August 30, 2023 02:05

lolodomo requested changes Nov 19, 2023

View reviewed changes

matchews requested a review from lolodomo November 21, 2023 20:25

matchews requested a review from jlaur December 23, 2023 15:28

matchews force-pushed the haywardomnilogic branch from a6e8f12 to 4a5a9f3 Compare February 11, 2024 14:55

matchews requested a review from lsiepel February 11, 2024 15:03

matchews force-pushed the haywardomnilogic branch from 4a5a9f3 to aa71ef6 Compare February 25, 2024 12:48

matchews force-pushed the haywardomnilogic branch from aa71ef6 to 130d95b Compare March 13, 2024 16:47

lsiepel added rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels Mar 31, 2024

lsiepel approved these changes Mar 31, 2024

View reviewed changes

matchews added 7 commits April 8, 2024 10:29

Update polling times based on Hayward API recommendations

51be53f

Signed-off-by: Matt Myers <[email protected]>

Added support for Hayward ColorLogic V2 Lights (Speed, Brightness & A…

b816157

…dditional Shows) Signed-off-by: Matt Myers <[email protected]>

Update chlorEnable based on updated getTelemetry API

8a6baa4

Signed-off-by: Matt Myers <[email protected]>

Updated chlorinator error, status and alert channels to string bit ar…

7e2c15f

…rays based on updated Hayward API Signed-off-by: Matt Myers <[email protected]>

Updates to deploy dimensionless:frequency, update patterns and option…

110734e

… values Signed-off-by: Matt Myers <[email protected]>

Update i18n properties

170a628

Signed-off-by: Matt Myers <[email protected]>

pumpHandler pumpRPM command bug fix

df81e9f

Signed-off-by: Matt Myers <[email protected]>

matchews added 6 commits April 8, 2024 10:29

Review changes requested by lolodomo

c793c0e

Signed-off-by: Matt Myers <[email protected]>

Added Thing upgrade instructions

8ff6929

Signed-off-by: Matt Myers <[email protected]>

Fix Readme.MD formatting

bb640a9

Signed-off-by: Matt Myers <[email protected]>

Fix Readme.MD formatting

abc92b4

Signed-off-by: Matt Myers <[email protected]>

Simplify bridge.getHandler() code

de0ce9f

Signed-off-by: Matt Myers <[email protected]>

rename instructions.xml

911c777

Signed-off-by: Matt Myers <[email protected]>

matchews force-pushed the haywardomnilogic branch from 9418966 to 911c777 Compare April 8, 2024 14:29

Fixed bug in thing update instructions

01d0500

Signed-off-by: Matt Myers <[email protected]>

matchews closed this Apr 9, 2024

matchews reopened this Apr 9, 2024

matchews requested a review from lsiepel April 10, 2024 10:52

lsiepel requested changes May 5, 2024

View reviewed changes

bundles/org.openhab.binding.haywardomnilogic/src/main/resources/OH-INF/thing/colorlogic.xml Show resolved Hide resolved

bundles/org.openhab.binding.haywardomnilogic/src/main/resources/OH-INF/thing/chlorinator.xml Show resolved Hide resolved

lsiepel approved these changes May 9, 2024

View reviewed changes

lsiepel merged commit 62e62e6 into openhab:main May 9, 2024
4 checks passed

lsiepel added this to the 4.2 milestone May 9, 2024

jlaur changed the title ~~[haywardomnilogic] Added support ColorLogic V2 Lights, Updated Chlor Enable, Alert, Error, Status~~ [haywardomnilogic] Add support for ColorLogic V2 Lights, Update Chlor Enable, Alert, Error, Status May 9, 2024

lsiepel mentioned this pull request May 28, 2024

[haywardomnilogic] Fix chlorinator bug #16820

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[haywardomnilogic] Add support for ColorLogic V2 Lights, Update Chlor Enable, Alert, Error, Status #15478

[haywardomnilogic] Add support for ColorLogic V2 Lights, Update Chlor Enable, Alert, Error, Status #15478

matchews commented Aug 22, 2023 •

edited

Loading

openhab-bot commented Aug 23, 2023

lolodomo commented Oct 18, 2023

matchews commented Oct 27, 2023

lolodomo left a comment

matchews commented Nov 21, 2023

matchews commented Dec 23, 2023

lsiepel commented Feb 25, 2024 •

edited

Loading

lsiepel left a comment

matchews commented Apr 9, 2024

lsiepel left a comment

lsiepel left a comment

matchews commented May 9, 2024 via email

lsiepel commented May 10, 2024

[haywardomnilogic] Add support for ColorLogic V2 Lights, Update Chlor Enable, Alert, Error, Status #15478

[haywardomnilogic] Add support for ColorLogic V2 Lights, Update Chlor Enable, Alert, Error, Status #15478

Conversation

matchews commented Aug 22, 2023 • edited Loading

openhab-bot commented Aug 23, 2023

lolodomo commented Oct 18, 2023

matchews commented Oct 27, 2023

lolodomo left a comment

Choose a reason for hiding this comment

matchews commented Nov 21, 2023

matchews commented Dec 23, 2023

lsiepel commented Feb 25, 2024 • edited Loading

lsiepel left a comment

Choose a reason for hiding this comment

matchews commented Apr 9, 2024

lsiepel left a comment

Choose a reason for hiding this comment

lsiepel left a comment

Choose a reason for hiding this comment

matchews commented May 9, 2024 via email

lsiepel commented May 10, 2024

matchews commented Aug 22, 2023 •

edited

Loading

lsiepel commented Feb 25, 2024 •

edited

Loading