Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hdpowerview] Add shade identify command #12175

Merged
merged 2 commits into from
Jan 31, 2022

Conversation

jlaur
Copy link
Contributor

@jlaur jlaur commented Jan 30, 2022

Fixes #12174

Signed-off-by: Jacob Laursen [email protected]

Add a command for identifying a shade by jogging it.

Extends #12138 to have more than one command and provides same functionality for shades as introduced for repeaters in #12061.

Fixes openhab#12174

Signed-off-by: Jacob Laursen <[email protected]>
@jlaur jlaur added the enhancement An enhancement or new feature for an existing add-on label Jan 30, 2022
@jlaur jlaur requested a review from lolodomo January 31, 2022 16:15
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lolodomo lolodomo merged commit fd6c8ee into openhab:main Jan 31, 2022
@lolodomo lolodomo added this to the 3.3 milestone Jan 31, 2022
NickWaterton pushed a commit to NickWaterton/openhab-addons that referenced this pull request Apr 27, 2022
* Add shade identify command.

Fixes openhab#12174 

Signed-off-by: Jacob Laursen <[email protected]>
Signed-off-by: Nick Waterton <[email protected]>
@jlaur jlaur deleted the 12174-hdpowerview-identify-shade branch June 13, 2022 16:58
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Jun 29, 2022
* Add shade identify command.

Fixes openhab#12174 

Signed-off-by: Jacob Laursen <[email protected]>
andan67 pushed a commit to andan67/openhab-addons that referenced this pull request Nov 6, 2022
* Add shade identify command.

Fixes openhab#12174 

Signed-off-by: Jacob Laursen <[email protected]>
andrasU pushed a commit to andrasU/openhab-addons that referenced this pull request Nov 12, 2022
* Add shade identify command.

Fixes openhab#12174 

Signed-off-by: Jacob Laursen <[email protected]>
Signed-off-by: Andras Uhrin <[email protected]>
psmedley pushed a commit to psmedley/openhab-addons that referenced this pull request Feb 23, 2023
* Add shade identify command.

Fixes openhab#12174 

Signed-off-by: Jacob Laursen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[hdpowerview] Add command for identifying a shade
2 participants