Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hdpowerview] Introduce command channel for shades #12138

Merged
merged 1 commit into from
Jan 27, 2022

Conversation

jlaur
Copy link
Contributor

@jlaur jlaur commented Jan 27, 2022

Signed-off-by: Jacob Laursen [email protected]

Refactor #12002 by changing the calibrate channel of type Switch to a command channel with option CALIBRATE.

I learned from #12061 (comment) about this possibility and it seems more appropriate here.

One more command is already in the pipeline: IDENTIFY.

@jlaur jlaur linked an issue Jan 27, 2022 that may be closed by this pull request
@jlaur jlaur requested a review from fwolter January 27, 2022 19:24
@jlaur
Copy link
Contributor Author

jlaur commented Jan 27, 2022

The previous pull request introducing the calibrate channel was merged into 3.3, so this is not a breaking change. It even might have a chance to get into same milestone release? :-)

@fwolter fwolter merged commit 369b985 into openhab:main Jan 27, 2022
@fwolter fwolter added the enhancement An enhancement or new feature for an existing add-on label Jan 27, 2022
@fwolter fwolter added this to the 3.3 milestone Jan 27, 2022
NickWaterton pushed a commit to NickWaterton/openhab-addons that referenced this pull request Apr 27, 2022
@jlaur jlaur deleted the 11767-hdpowerview-calibrate-command branch June 13, 2022 17:02
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Jun 29, 2022
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/hd-powerview-binding-issue-openhab-3-3-0/136921/36

andan67 pushed a commit to andan67/openhab-addons that referenced this pull request Nov 6, 2022
andrasU pushed a commit to andrasU/openhab-addons that referenced this pull request Nov 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[hdpowerview] Add support for calibrating a shade
3 participants