-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[hdpowerview] Optimize initialization of shades #12113
Merged
fwolter
merged 2 commits into
openhab:main
from
jlaur:12071-hdpowerview-shade-initialization
Jan 28, 2022
Merged
[hdpowerview] Optimize initialization of shades #12113
fwolter
merged 2 commits into
openhab:main
from
jlaur:12071-hdpowerview-shade-initialization
Jan 28, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlaur
added
enhancement
An enhancement or new feature for an existing add-on
work in progress
A PR that is not yet ready to be merged
labels
Jan 24, 2022
andrewfg
requested changes
Jan 25, 2022
...ew/src/main/java/org/openhab/binding/hdpowerview/internal/handler/HDPowerViewHubHandler.java
Outdated
Show resolved
Hide resolved
...ew/src/main/java/org/openhab/binding/hdpowerview/internal/handler/HDPowerViewHubHandler.java
Outdated
Show resolved
Hide resolved
andrewfg
approved these changes
Jan 25, 2022
jlaur
force-pushed
the
12071-hdpowerview-shade-initialization
branch
from
January 25, 2022 19:12
7461ee1
to
d2e5bf3
Compare
@fwolter - sorry to exploit you a little, but #12061 (comment) seems to suggest that these channel state changes is your ball game, so maybe you could also have a look at this one now that we're at it? :-) |
Fixes openhab#12071 Signed-off-by: Jacob Laursen <[email protected]>
Signed-off-by: Jacob Laursen <[email protected]>
jlaur
force-pushed
the
12071-hdpowerview-shade-initialization
branch
from
January 27, 2022 22:08
d2e5bf3
to
d0b53e8
Compare
fwolter
approved these changes
Jan 28, 2022
NickWaterton
pushed a commit
to NickWaterton/openhab-addons
that referenced
this pull request
Apr 27, 2022
* Optimize initialization of shades. Fixes openhab#12071 Signed-off-by: Jacob Laursen <[email protected]> * Avoid hashmap reallocation during initialization. Signed-off-by: Jacob Laursen <[email protected]> Signed-off-by: Nick Waterton <[email protected]>
nemerdaud
pushed a commit
to nemerdaud/openhab-addons
that referenced
this pull request
Jun 29, 2022
* Optimize initialization of shades. Fixes openhab#12071 Signed-off-by: Jacob Laursen <[email protected]> * Avoid hashmap reallocation during initialization. Signed-off-by: Jacob Laursen <[email protected]>
andan67
pushed a commit
to andan67/openhab-addons
that referenced
this pull request
Nov 6, 2022
* Optimize initialization of shades. Fixes openhab#12071 Signed-off-by: Jacob Laursen <[email protected]> * Avoid hashmap reallocation during initialization. Signed-off-by: Jacob Laursen <[email protected]>
andrasU
pushed a commit
to andrasU/openhab-addons
that referenced
this pull request
Nov 12, 2022
* Optimize initialization of shades. Fixes openhab#12071 Signed-off-by: Jacob Laursen <[email protected]> * Avoid hashmap reallocation during initialization. Signed-off-by: Jacob Laursen <[email protected]> Signed-off-by: Andras Uhrin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12071 - please see this issue for further details.
Signed-off-by: Jacob Laursen [email protected]
This pull request fixes a concurrency issue and optimizes the status transitions for shades to come online as fast as possible:
Example of transitions for a single shade after the changes:
Planned for next PR in this area: