-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[insteon] Set device offline if it doesn't exist in the plm/hub database #12904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rob Nielsen <[email protected]>
robnielsen
added
the
bug
An unexpected problem or unintended behavior of an add-on
label
Jun 7, 2022
lolodomo
requested changes
Jun 8, 2022
...insteon/src/main/java/org/openhab/binding/insteon/internal/handler/InsteonDeviceHandler.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Rob Nielsen <[email protected]>
lolodomo
requested changes
Jun 10, 2022
...nsteon/src/main/java/org/openhab/binding/insteon/internal/handler/InsteonNetworkHandler.java
Outdated
Show resolved
Hide resolved
...insteon/src/main/java/org/openhab/binding/insteon/internal/handler/InsteonDeviceHandler.java
Show resolved
Hide resolved
...insteon/src/main/java/org/openhab/binding/insteon/internal/handler/InsteonDeviceHandler.java
Show resolved
Hide resolved
@jlaur : please have a look and merge if that is fine for you. |
jlaur
requested changes
Jun 13, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. A few comments to consider.
...insteon/src/main/java/org/openhab/binding/insteon/internal/handler/InsteonDeviceHandler.java
Show resolved
Hide resolved
...insteon/src/main/java/org/openhab/binding/insteon/internal/handler/InsteonDeviceHandler.java
Outdated
Show resolved
Hide resolved
...insteon/src/main/java/org/openhab/binding/insteon/internal/handler/InsteonDeviceHandler.java
Outdated
Show resolved
Hide resolved
...nsteon/src/main/java/org/openhab/binding/insteon/internal/handler/InsteonNetworkHandler.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Rob Nielsen <[email protected]>
Signed-off-by: Rob Nielsen <[email protected]>
jlaur
approved these changes
Jun 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
jlaur
changed the title
[insteon] set device offline if it doesn't exist in the plm/hub database
[insteon] Set device offline if it doesn't exist in the plm/hub database
Jun 14, 2022
leifbladt
pushed a commit
to leifbladt/openhab-addons
that referenced
this pull request
Oct 15, 2022
…ase (openhab#12904) * [insteon] set device offline if it doesn't exist in the plm/hub database * [insteon] use a flag to indicate if a device is linked or not * [insteon] set config to @NonNullByDefault({}) instead of @nullable * [insteon] cleanup Signed-off-by: Rob Nielsen <[email protected]>
andan67
pushed a commit
to andan67/openhab-addons
that referenced
this pull request
Nov 6, 2022
…ase (openhab#12904) * [insteon] set device offline if it doesn't exist in the plm/hub database * [insteon] use a flag to indicate if a device is linked or not * [insteon] set config to @NonNullByDefault({}) instead of @nullable * [insteon] cleanup Signed-off-by: Rob Nielsen <[email protected]>
andrasU
pushed a commit
to andrasU/openhab-addons
that referenced
this pull request
Nov 12, 2022
…ase (openhab#12904) * [insteon] set device offline if it doesn't exist in the plm/hub database * [insteon] use a flag to indicate if a device is linked or not * [insteon] set config to @NonNullByDefault({}) instead of @nullable * [insteon] cleanup Signed-off-by: Rob Nielsen <[email protected]> Signed-off-by: Andras Uhrin <[email protected]>
psmedley
pushed a commit
to psmedley/openhab-addons
that referenced
this pull request
Feb 23, 2023
…ase (openhab#12904) * [insteon] set device offline if it doesn't exist in the plm/hub database * [insteon] use a flag to indicate if a device is linked or not * [insteon] set config to @NonNullByDefault({}) instead of @nullable * [insteon] cleanup Signed-off-by: Rob Nielsen <[email protected]>
nemerdaud
pushed a commit
to nemerdaud/openhab-addons
that referenced
this pull request
Feb 28, 2023
…ase (openhab#12904) * [insteon] set device offline if it doesn't exist in the plm/hub database * [insteon] use a flag to indicate if a device is linked or not * [insteon] set config to @NonNullByDefault({}) instead of @nullable * [insteon] cleanup Signed-off-by: Rob Nielsen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #12903