Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[insteon] Set device offline if it doesn't exist in the plm/hub database #12904

Merged
merged 4 commits into from
Jun 14, 2022

Conversation

robnielsen
Copy link
Contributor

This fixes #12903

@robnielsen robnielsen added the bug An unexpected problem or unintended behavior of an add-on label Jun 7, 2022
@robnielsen robnielsen requested a review from lolodomo June 8, 2022 11:43
@lolodomo
Copy link
Contributor

@jlaur : please have a look and merge if that is fine for you.

@robnielsen robnielsen requested a review from lolodomo June 11, 2022 14:24
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. A few comments to consider.

@robnielsen robnielsen requested a review from jlaur June 13, 2022 22:07
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@jlaur jlaur merged commit 3349cf4 into openhab:main Jun 14, 2022
@jlaur jlaur added this to the 3.3 milestone Jun 14, 2022
@jlaur jlaur changed the title [insteon] set device offline if it doesn't exist in the plm/hub database [insteon] Set device offline if it doesn't exist in the plm/hub database Jun 14, 2022
leifbladt pushed a commit to leifbladt/openhab-addons that referenced this pull request Oct 15, 2022
…ase (openhab#12904)

* [insteon] set device offline if it doesn't exist in the plm/hub database
* [insteon] use a flag to indicate if a device is linked or not
* [insteon] set config to @NonNullByDefault({}) instead of @nullable
* [insteon] cleanup

Signed-off-by: Rob Nielsen <[email protected]>
andan67 pushed a commit to andan67/openhab-addons that referenced this pull request Nov 6, 2022
…ase (openhab#12904)

* [insteon] set device offline if it doesn't exist in the plm/hub database
* [insteon] use a flag to indicate if a device is linked or not
* [insteon] set config to @NonNullByDefault({}) instead of @nullable
* [insteon] cleanup

Signed-off-by: Rob Nielsen <[email protected]>
andrasU pushed a commit to andrasU/openhab-addons that referenced this pull request Nov 12, 2022
…ase (openhab#12904)

* [insteon] set device offline if it doesn't exist in the plm/hub database
* [insteon] use a flag to indicate if a device is linked or not
* [insteon] set config to @NonNullByDefault({}) instead of @nullable
* [insteon] cleanup

Signed-off-by: Rob Nielsen <[email protected]>
Signed-off-by: Andras Uhrin <[email protected]>
psmedley pushed a commit to psmedley/openhab-addons that referenced this pull request Feb 23, 2023
…ase (openhab#12904)

* [insteon] set device offline if it doesn't exist in the plm/hub database
* [insteon] use a flag to indicate if a device is linked or not
* [insteon] set config to @NonNullByDefault({}) instead of @nullable
* [insteon] cleanup

Signed-off-by: Rob Nielsen <[email protected]>
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Feb 28, 2023
…ase (openhab#12904)

* [insteon] set device offline if it doesn't exist in the plm/hub database
* [insteon] use a flag to indicate if a device is linked or not
* [insteon] set config to @NonNullByDefault({}) instead of @nullable
* [insteon] cleanup

Signed-off-by: Rob Nielsen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[insteon] device is improperly set to ONLINE when device doesn't exist in modem database
4 participants