[enocean] Fix concurrency exception on startup #11408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Lauterbach <[email protected]>
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/new-openhab2-enocean-binding/39917/1059 |
DrRSatzteil
changed the title
DrRSatzteil
changed the title
|
I just realised that there's also an open issue: #11393 |
* synchronized access to listeners and eventListeners collections of EnOceanTransceiver * reverted ConcurrentHashMap change as NULL-Key is required Fixes openhab#11393 Signed-off-by: Daniel Weber <[email protected]>
|
@DrRSatzteil |
fruggy83
approved these changes
Oct 19, 2021
kaikreuzer
added
rebuild
kaikreuzer
approved these changes
Oct 20, 2021
kaikreuzer
added
the
bug
dschoepel
pushed a commit
to dschoepel/openhab-addons
that referenced
this pull request
Nov 9, 2021
* made listeners a ConcurrentHashMap * synchronized access to listeners and eventListeners collections of EnOceanTransceiver * reverted ConcurrentHashMap change as NULL-Key is required Fixes openhab#11393 Also-by: Daniel Weber <[email protected]> Signed-off-by: Thomas Lauterbach <[email protected]> Signed-off-by: Dave J Schoepel <[email protected]>
NickWaterton
pushed a commit
to NickWaterton/openhab-addons
that referenced
this pull request
Dec 30, 2021
* made listeners a ConcurrentHashMap * synchronized access to listeners and eventListeners collections of EnOceanTransceiver * reverted ConcurrentHashMap change as NULL-Key is required Fixes openhab#11393 Also-by: Daniel Weber <[email protected]> Signed-off-by: Thomas Lauterbach <[email protected]> Signed-off-by: Nick Waterton <[email protected]>
nemerdaud
pushed a commit
to nemerdaud/openhab-addons
that referenced
this pull request
Jan 28, 2022
* made listeners a ConcurrentHashMap * synchronized access to listeners and eventListeners collections of EnOceanTransceiver * reverted ConcurrentHashMap change as NULL-Key is required Fixes openhab#11393 Also-by: Daniel Weber <[email protected]> Signed-off-by: Thomas Lauterbach <[email protected]>
marcfischerboschio
pushed a commit
to bosch-io/openhab-addons
that referenced
this pull request
May 5, 2022
* made listeners a ConcurrentHashMap * synchronized access to listeners and eventListeners collections of EnOceanTransceiver * reverted ConcurrentHashMap change as NULL-Key is required Fixes openhab#11393 Also-by: Daniel Weber <[email protected]> Signed-off-by: Thomas Lauterbach <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Thomas Lauterbach [email protected]
This PR fixed a ConcurrentModificationException on startup preventing some child things of the bridge to not come online. See https://community.openhab.org/t/new-openhab2-enocean-binding/39917/1059?u=drrsatzteil