Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enocean: ConcurrentModificationException while startup #11393

Closed
UrsusS opened this issue Oct 16, 2021 · 1 comment
Closed

enocean: ConcurrentModificationException while startup #11393

UrsusS opened this issue Oct 16, 2021 · 1 comment
Labels
bug An unexpected problem or unintended behavior of an add-on

Comments

@UrsusS
Copy link

UrsusS commented Oct 16, 2021

On startup of openHAB 3.2.0.M3 I received this error:

2021-10-16 12:43:31.567 [ERROR] [core.thing.internal.ThingManagerImpl] - Exception occurred during notification about bridge status change on thing 'enocean:mechanicalHandle:FT1ZI6SV:FensterGriffWoZiWiGa': null
java.util.ConcurrentModificationException: null
	at java.util.HashMap.computeIfAbsent(HashMap.java:1134) ~[?:?]
	at org.openhab.binding.enocean.internal.transceiver.EnOceanTransceiver.addPacketListener(EnOceanTransceiver.java:378) ~[?:?]
	at org.openhab.binding.enocean.internal.handler.EnOceanBridgeHandler.addPacketListener(EnOceanBridgeHandler.java:383) ~[?:?]
	at org.openhab.binding.enocean.internal.handler.EnOceanBridgeHandler.addPacketListener(EnOceanBridgeHandler.java:378) ~[?:?]
	at org.openhab.binding.enocean.internal.handler.EnOceanBaseSensorHandler.validateConfig(EnOceanBaseSensorHandler.java:105) ~[?:?]
	at org.openhab.binding.enocean.internal.handler.EnOceanBaseThingHandler.initializeThing(EnOceanBaseThingHandler.java:99) ~[?:?]
	at org.openhab.binding.enocean.internal.handler.EnOceanBaseThingHandler.bridgeStatusChanged(EnOceanBaseThingHandler.java:259) ~[?:?]
	at org.openhab.core.thing.internal.ThingManagerImpl$5.run(ThingManagerImpl.java:964) [bundleFile:?]
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515) [?:?]
	at java.util.concurrent.FutureTask.run(FutureTask.java:264) [?:?]
	at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:304) [?:?]
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) [?:?]
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) [?:?]
	at java.lang.Thread.run(Thread.java:829) [?:?]

In total there are 6 mechanicalHandles, one genericThing and one temperatureHumiditySensor defined.
Only the thing which throws that error does not work. Reloading of the thing-file solved that.

Bridge enocean:bridge:FT1ZI6SV	"EnOcean Gateway" @ "Flur EG"
[
	path="/dev/ttyUSB0",
	enableSmack=true,
	espVersion="ESP3"
]
{
	Thing mechanicalHandle FensterGriffWoZiWiGa			"Türgriff Wohnzimmer-Wintergarten" @ "Wohnzimmer"
	[
		enoceanId="0517E6EE",
		receivingEEPId="F6_10_00"
	]
}
@UrsusS UrsusS added the bug An unexpected problem or unintended behavior of an add-on label Oct 16, 2021
@DrRSatzteil
Copy link
Contributor

This bug also exists in versions prior to 3.2

I'm on 3.1 and I also observe this from time to time

fruggy83 added a commit to DrRSatzteil/openhab-addons that referenced this issue Oct 19, 2021
* synchronized access to listeners and eventListeners collections of EnOceanTransceiver
* reverted ConcurrentHashMap change as NULL-Key is required

Fixes openhab#11393

Signed-off-by: Daniel Weber <[email protected]>
dschoepel pushed a commit to dschoepel/openhab-addons that referenced this issue Nov 9, 2021
* made listeners a ConcurrentHashMap
* synchronized access to listeners and eventListeners collections of EnOceanTransceiver
* reverted ConcurrentHashMap change as NULL-Key is required

Fixes openhab#11393

Also-by: Daniel Weber <[email protected]>
Signed-off-by: Thomas Lauterbach <[email protected]>
Signed-off-by: Dave J Schoepel <[email protected]>
NickWaterton pushed a commit to NickWaterton/openhab-addons that referenced this issue Dec 30, 2021
* made listeners a ConcurrentHashMap
* synchronized access to listeners and eventListeners collections of EnOceanTransceiver
* reverted ConcurrentHashMap change as NULL-Key is required

Fixes openhab#11393

Also-by: Daniel Weber <[email protected]>
Signed-off-by: Thomas Lauterbach <[email protected]>
Signed-off-by: Nick Waterton <[email protected]>
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this issue Jan 28, 2022
* made listeners a ConcurrentHashMap
* synchronized access to listeners and eventListeners collections of EnOceanTransceiver
* reverted ConcurrentHashMap change as NULL-Key is required

Fixes openhab#11393

Also-by: Daniel Weber <[email protected]>
Signed-off-by: Thomas Lauterbach <[email protected]>
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this issue May 5, 2022
* made listeners a ConcurrentHashMap
* synchronized access to listeners and eventListeners collections of EnOceanTransceiver
* reverted ConcurrentHashMap change as NULL-Key is required

Fixes openhab#11393

Also-by: Daniel Weber <[email protected]>
Signed-off-by: Thomas Lauterbach <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Development

No branches or pull requests

2 participants