[danfossairunit] Add filter period channel #11371
Conversation
There was a problem hiding this comment.
Besides the issue with retrieving the max filter period the changes look good to me. But under the circumstances (I think it might even be a bug in the CCM), using fixed values seems reasonable - at least they are the correct ones then.
Thanks also for giving the documentation samples a polish.
|
@pravussum - I left some more thoughts in the linked issue. Right now I'm thinking having the channel provides most flexibility, and it would be possible to write a rule with a RemainingFilterLife proxy item that could be updated only when receiving recalculated value having the desired filter period set. |
Skinah
added
the
enhancement
|
@Skinah - I saw you added label two days ago, would it be possible for you to schedule a rebuild or add the rebuild tag as last build failed for reasons unrelated to changes in this PR? |
...danfossairunit/src/main/java/org/openhab/binding/danfossairunit/internal/DanfossAirUnit.java
Outdated
Show resolved
Hide resolved
Fixes openhab#11310 Signed-off-by: Jacob Laursen <[email protected]>
Signed-off-by: Jacob Laursen <[email protected]>
Signed-off-by: Jacob Laursen <[email protected]>
…cts. Signed-off-by: Jacob Laursen <[email protected]>
Signed-off-by: Jacob Laursen <[email protected]>
Signed-off-by: Jacob Laursen <[email protected]>
…n' contribution description. Signed-off-by: Jacob Laursen <[email protected]>
Signed-off-by: Jacob Laursen <[email protected]>
jlaur
force-pushed
the
11310-danfossairunit-filter-period-channel
branch
from
3fb6458 to
d05a198
Compare
lolodomo
added
rebuild
|
All the new PR's are failing at the moment so it is probably a build system issue, when new PR's pass again it will be worth triggering a rebuild then otherwise it will just chew up the servers time if we expect it to fail not due to your code. |
|
I tried after maintainers were informed the build problem could have been solved. |
kaikreuzer
added
rebuild
|
@jlaur : I see you have discussion about the documentation in the issue. Is there still something to change in the documentation or is it finished and ready for a merge ? |
No further documentation plans from my side, as only one channel is exposed and there's already a warning about value being overwritten. If @pravussum would have any ideas for further documentation improvements, I can prepare another PR. |
|
Thank you |
* Add filter period channel. Fixes openhab#11310 Signed-off-by: Jacob Laursen <[email protected]> * Round remaining filter life percentage to one decimal. Signed-off-by: Jacob Laursen <[email protected]> * Improve and extend example configuration. Signed-off-by: Jacob Laursen <[email protected]> * Mark filter period channel as advanced due to Link CC/Air Dial conflicts. Signed-off-by: Jacob Laursen <[email protected]> * Add comment about value getting overwritten. Signed-off-by: Jacob Laursen <[email protected]> * Remove redundant parentheses. Signed-off-by: Jacob Laursen <[email protected]> * Fix SCA report: First javadoc author should have 'Initial contribution' contribution description. Signed-off-by: Jacob Laursen <[email protected]> * Fix SCA issue: NoEmptyLineSeparatorCheck Signed-off-by: Jacob Laursen <[email protected]> Signed-off-by: Dave J Schoepel <[email protected]>
* Add filter period channel. Fixes openhab#11310 Signed-off-by: Jacob Laursen <[email protected]> * Round remaining filter life percentage to one decimal. Signed-off-by: Jacob Laursen <[email protected]> * Improve and extend example configuration. Signed-off-by: Jacob Laursen <[email protected]> * Mark filter period channel as advanced due to Link CC/Air Dial conflicts. Signed-off-by: Jacob Laursen <[email protected]> * Add comment about value getting overwritten. Signed-off-by: Jacob Laursen <[email protected]> * Remove redundant parentheses. Signed-off-by: Jacob Laursen <[email protected]> * Fix SCA report: First javadoc author should have 'Initial contribution' contribution description. Signed-off-by: Jacob Laursen <[email protected]> * Fix SCA issue: NoEmptyLineSeparatorCheck Signed-off-by: Jacob Laursen <[email protected]> Signed-off-by: Nick Waterton <[email protected]>
* Add filter period channel. Fixes openhab#11310 Signed-off-by: Jacob Laursen <[email protected]> * Round remaining filter life percentage to one decimal. Signed-off-by: Jacob Laursen <[email protected]> * Improve and extend example configuration. Signed-off-by: Jacob Laursen <[email protected]> * Mark filter period channel as advanced due to Link CC/Air Dial conflicts. Signed-off-by: Jacob Laursen <[email protected]> * Add comment about value getting overwritten. Signed-off-by: Jacob Laursen <[email protected]> * Remove redundant parentheses. Signed-off-by: Jacob Laursen <[email protected]> * Fix SCA report: First javadoc author should have 'Initial contribution' contribution description. Signed-off-by: Jacob Laursen <[email protected]> * Fix SCA issue: NoEmptyLineSeparatorCheck Signed-off-by: Jacob Laursen <[email protected]>
* Add filter period channel. Fixes openhab#11310 Signed-off-by: Jacob Laursen <[email protected]> * Round remaining filter life percentage to one decimal. Signed-off-by: Jacob Laursen <[email protected]> * Improve and extend example configuration. Signed-off-by: Jacob Laursen <[email protected]> * Mark filter period channel as advanced due to Link CC/Air Dial conflicts. Signed-off-by: Jacob Laursen <[email protected]> * Add comment about value getting overwritten. Signed-off-by: Jacob Laursen <[email protected]> * Remove redundant parentheses. Signed-off-by: Jacob Laursen <[email protected]> * Fix SCA report: First javadoc author should have 'Initial contribution' contribution description. Signed-off-by: Jacob Laursen <[email protected]> * Fix SCA issue: NoEmptyLineSeparatorCheck Signed-off-by: Jacob Laursen <[email protected]>
Fixes #11310
Signed-off-by: Jacob Laursen [email protected]
Add new channel filter_life for number of months between filter replacements.