Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hueemulation] Fix xy change response #10692

Merged
merged 1 commit into from
Dec 11, 2021
Merged

Conversation

Flole998
Copy link
Member

@Flole998 Flole998 commented May 14, 2021

Fixes the following problem mentioned in #10691 :

  • In HueSuccessResponseStateChanged.java the serializer for lists is missing, so when setting xy the response is missing that it changed xy

@Flole998 Flole998 force-pushed the huefix branch 3 times, most recently from 4772c36 to 9c2480a Compare May 15, 2021 00:16
@Flole998 Flole998 changed the title Hueemulation: Fix xy change response and fix light IDs Hueemulation: Fix xy change response May 15, 2021
@Flole998 Flole998 requested a review from MikeJMajor May 21, 2021 00:55
@kaikreuzer kaikreuzer added rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels May 21, 2021
Copy link
Contributor

@MikeJMajor MikeJMajor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the switchOnWithXY test in LightsAndGroupsTests to explicitly check the response contains "xy"

@Skinah Skinah added the bug An unexpected problem or unintended behavior of an add-on label Sep 7, 2021
@Flole998
Copy link
Member Author

Flole998 commented Nov 1, 2021

@davidgraeff Could you please review this real quick?

@Flole998
Copy link
Member Author

@digitaldan Maybe you can review this? It's just a small change, shouldn't take long.

@Flole998
Copy link
Member Author

Flole998 commented Dec 7, 2021

@kaikreuzer As nobody else seems to want to review this PR, maybe you could do it? It's a rather simple change, so I have no clue why it's taking so long....

@lolodomo lolodomo merged commit ebf2a76 into openhab:main Dec 11, 2021
@lolodomo lolodomo added this to the 3.2 milestone Dec 11, 2021
@wborn wborn changed the title Hueemulation: Fix xy change response [hueemulation] Fix xy change response Dec 18, 2021
NickWaterton pushed a commit to NickWaterton/openhab-addons that referenced this pull request Dec 30, 2021
mischmidt83 pushed a commit to mischmidt83/openhab-addons that referenced this pull request Jan 9, 2022
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Jan 28, 2022
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
andan67 pushed a commit to andan67/openhab-addons that referenced this pull request Nov 6, 2022
andrasU pushed a commit to andrasU/openhab-addons that referenced this pull request Nov 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants