Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hueemulation] Several API-Issues #10691

Open
2 of 3 tasks
Flole998 opened this issue May 14, 2021 · 4 comments
Open
2 of 3 tasks

[hueemulation] Several API-Issues #10691

Flole998 opened this issue May 14, 2021 · 4 comments
Labels
awaiting feedback Awaiting feedback from the pull request author bug An unexpected problem or unintended behavior of an add-on stale As soon as a PR is marked stale, it can be removed 6 months later.

Comments

@Flole998
Copy link
Member

Flole998 commented May 14, 2021

There are several things the Hue-Emulation doesn't handle properly which makes it have issues with some devices:

  • It redirects /api to /api/
  • It uses leading zeros for the light names/numbers and expects them. Some devices omit leading zeros, this causes issues
  • In HueSuccessResponseStateChanged.java the serializer for lists is missing, so when setting xy the response is missing that it changed xy
@Flole998 Flole998 added the bug An unexpected problem or unintended behavior of an add-on label May 14, 2021
@lsiepel
Copy link
Contributor

lsiepel commented Jan 1, 2024

@Flole998 Is this is an older issue can you comment if this change is still needed?

@lsiepel lsiepel added the awaiting feedback Awaiting feedback from the pull request author label Jan 1, 2024
@Flole998
Copy link
Member Author

Flole998 commented Jan 2, 2024

@lsiepel This is still an issur.

@lsiepel lsiepel removed the awaiting feedback Awaiting feedback from the pull request author label Jan 2, 2024
@lsiepel
Copy link
Contributor

lsiepel commented Jan 2, 2024

Are you able to come up with a PR or how would you want to proceed?

If the redirect from /api to /api/ is the only issue left to fix, it might be simple. But changing this behaviour might cause regressions. Do you some example client that has an issue with hueemulation?

@lsiepel lsiepel added the awaiting feedback Awaiting feedback from the pull request author label Feb 10, 2024
Copy link

stale bot commented Apr 11, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale As soon as a PR is marked stale, it can be removed 6 months later. label Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting feedback Awaiting feedback from the pull request author bug An unexpected problem or unintended behavior of an add-on stale As soon as a PR is marked stale, it can be removed 6 months later.
Projects
None yet
Development

No branches or pull requests

2 participants