[ValloxMV] Add Co2 measurement for ValloxMV binding #10532
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: bjoernbrings <[email protected]>
Signed-off-by: bjoernbrings <[email protected]> Co-authored-by: Fabian Wolter <[email protected]>
Fixed Co2 reading (from humidity)
mikaelgu80
changed the title
|
My first two commits are already included in #10324 |
|
Thanks for fetching that mistake |
fwolter
requested changes
Apr 16, 2021
Comment on lines
2
to
3
| binding.valloxmv.name = Vallox L�ftungsanlagen | ||
| binding.valloxmv.description = Binding f�r das Online-Interface von Vallox L�ftungsanlagen | ||
| binding.valloxmv.name = Vallox Lüftungsanlagen | ||
| binding.valloxmv.description = Binding für das Online-Interface von Vallox Lüftungsanlagen |
There was a problem hiding this comment.
The properties file shall be ISO 8859-1. You made it UTF-8.
Unnecessary for this pull request.
Unnecessary for this pull request.
Unnecessary for this pull request.
|
I'll try this again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugfix: Co2 measurement was added to the binding for 3.1.0, but there was an erroneus line that resulted in humidity reading being used as Co2. This PR is meant to fix that issue.