[ValloxMV] Adding Co2 measurement #10324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: bjoernbrings <[email protected]>
bjoernbrings
changed the title
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/vallox-mv-binding-co2-reading/118782/7 |
fwolter
requested changes
Mar 15, 2021
....binding.valloxmv/src/main/java/org/openhab/binding/valloxmv/internal/ValloxMVWebSocket.java
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.valloxmv/src/main/resources/OH-INF/i18n/valloxmv_de.properties
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.valloxmv/src/main/resources/OH-INF/i18n/valloxmv_de.properties
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.valloxmv/src/main/resources/OH-INF/thing/thing-types.xml
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.valloxmv/src/main/resources/OH-INF/thing/thing-types.xml
Outdated
Show resolved
Hide resolved
Signed-off-by: bjoernbrings <[email protected]> Co-authored-by: Fabian Wolter <[email protected]>
bjoernbrings
force-pushed
the
ValloxMV_CO2
branch
from
7a2c717 to
7469745
Compare
|
Thanks for your input |
kaikreuzer
added
the
enhancement
themillhousegroup
pushed a commit
to themillhousegroup/openhab2-addons
that referenced
this pull request
May 10, 2021
Signed-off-by: bjoernbrings <[email protected]> Signed-off-by: John Marshall <[email protected]>
computergeek1507
pushed a commit
to computergeek1507/openhab-addons
that referenced
this pull request
Jul 13, 2021
Signed-off-by: bjoernbrings <[email protected]>
thinkingstone
pushed a commit
to thinkingstone/openhab-addons
that referenced
this pull request
Nov 7, 2021
Signed-off-by: bjoernbrings <[email protected]>
marcfischerboschio
pushed a commit
to bosch-io/openhab-addons
that referenced
this pull request
May 5, 2022
Signed-off-by: bjoernbrings <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For ValloxMV binding I added a channel for CO2 measurement and corrected one bug for humidity measurement (in fact it was working but seems like it was using a wrong register).
I don't have a unit with CO2 measurement but it has been tested by a user here.
Signed-off-by: bjoernbrings [email protected]