[tr064] Use Util.getAndUnmarshalXML method to retrieve phonebook #10447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…meout 5s and cacheing) Signed-off-by: Christoph Weitkamp <[email protected]>
cweitkamp
added
the
enhancement
|
Hello Christoph,
Of course, if it helps :)
I‘m not so familiar with Java, just proud to make my very first change 😂
I think yours is much better than just raise the timeout ;)
Mobil gesendet
… Am 05.04.2021 um 11:11 schrieb Christoph Weitkamp ***@***.***>:
I am running this version in my prod environment for two days now without seeing the error described in #10436 anymore.
@JensHoRi would it be okay for you to replace your PR (#10441) by this one?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
Alright. I closed your PR. Please do not refuse to create more PRs. |
themillhousegroup
pushed a commit
to themillhousegroup/openhab2-addons
that referenced
this pull request
May 10, 2021
…ports timeout 5s and caching) (openhab#10447) Fixes openhab#10436 Signed-off-by: Christoph Weitkamp <[email protected]> Signed-off-by: John Marshall <[email protected]>
computergeek1507
pushed a commit
to computergeek1507/openhab-addons
that referenced
this pull request
Jul 13, 2021
…ports timeout 5s and caching) (openhab#10447) Fixes openhab#10436 Signed-off-by: Christoph Weitkamp <[email protected]>
thinkingstone
pushed a commit
to thinkingstone/openhab-addons
that referenced
this pull request
Nov 7, 2021
…ports timeout 5s and caching) (openhab#10447) Fixes openhab#10436 Signed-off-by: Christoph Weitkamp <[email protected]>
marcfischerboschio
pushed a commit
to bosch-io/openhab-addons
that referenced
this pull request
May 5, 2022
…ports timeout 5s and caching) (openhab#10447) Fixes openhab#10436 Signed-off-by: Christoph Weitkamp <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Util.getAndUnmarshalXML(...)method to retrieve phonebook (the method supports timeout 5s and caching)Fixes #10436
Signed-off-by: Christoph Weitkamp [email protected]