Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openhab TR064-Binding Timeout while downloading phonebook #10436

Closed
JensHoRi opened this issue Apr 2, 2021 · 0 comments · Fixed by #10447
Closed

openhab TR064-Binding Timeout while downloading phonebook #10436

JensHoRi opened this issue Apr 2, 2021 · 0 comments · Fixed by #10447
Labels
bug An unexpected problem or unintended behavior of an add-on

Comments

@JensHoRi
Copy link

JensHoRi commented Apr 2, 2021

Tested with actual TR064 Binding and openhab3.1.0 M3:

If phonebook exceeds an unknown size, the download takes longer than 2000ms which seems to be a hard coded timeout for downloading the phonebook.

All phonebooks with a few entries got downloaded fine and working. But bigger phonebooks don't

small one:

2021-04-02 18:19:38.311 [DEBUG] [nternal.phonebook.Tr064PhonebookImpl] - Downloaded phonebook Test: {0XXXXXXXXX=NAME, **50=ISDN/DECT Rundruf, **43=Wecker 3, **42=Wecker 2, YYYYYYYYY=NAME, **41=Wecker 1, **1=DECT Wohnung, **2=Fax Büro, **623=DEVICE, **600=Anrufbeantworter, **622=DEVICE, **621=DEVICE, **605=Anrufbeantworter, **9=Alle (Rundruf)}

Bigger one:

2021-04-02 18:19:40.341 [WARN ] [nternal.phonebook.Tr064PhonebookImpl] - Failed to get phonebook with URL https://192.xxx.xxx.x:49443/phonebook.lua?sid=yyyyyyyyyyyyyyyyyyyyyyyyy:
2021-04-02 18:19:40.341 [WARN ] [nternal.phonebook.Tr064PhonebookImpl] - Failed to get phonebook with URL https://192.xxx.xxx.x:49443/phonebook.lua?sid=yyyyyyyyyyyyyyyyyyyyyyyyyyy:
java.util.concurrent.TimeoutException: Total timeout 2000 ms elapsed
        at org.eclipse.jetty.client.TimeoutCompleteListener.onTimeoutExpired(TimeoutCompleteListener.java:51) ~[?:?]
        at org.eclipse.jetty.io.CyclicTimeout$Wakeup.run(CyclicTimeout.java:282) ~[?:?]
        at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515) [?:?]
        at java.util.concurrent.FutureTask.run(FutureTask.java:264) [?:?]
        at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:304) [?:?]
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) [?:?]
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) [?:?]
        at java.lang.Thread.run(Thread.java:834) [?:?]

So please increase timeout or otherwise (my suggestion) make it configureable within Bridge with parameter phonebookTimeout

Thanks for great work of all developers.

@JensHoRi JensHoRi added the bug An unexpected problem or unintended behavior of an add-on label Apr 2, 2021
@cweitkamp cweitkamp linked a pull request Apr 3, 2021 that will close this issue
wborn pushed a commit that referenced this issue Apr 7, 2021
…ports timeout 5s and caching) (#10447)

Fixes #10436

Signed-off-by: Christoph Weitkamp <[email protected]>
themillhousegroup pushed a commit to themillhousegroup/openhab2-addons that referenced this issue May 10, 2021
…ports timeout 5s and caching) (openhab#10447)

Fixes openhab#10436

Signed-off-by: Christoph Weitkamp <[email protected]>
Signed-off-by: John Marshall <[email protected]>
computergeek1507 pushed a commit to computergeek1507/openhab-addons that referenced this issue Jul 13, 2021
…ports timeout 5s and caching) (openhab#10447)

Fixes openhab#10436

Signed-off-by: Christoph Weitkamp <[email protected]>
thinkingstone pushed a commit to thinkingstone/openhab-addons that referenced this issue Nov 7, 2021
…ports timeout 5s and caching) (openhab#10447)

Fixes openhab#10436

Signed-off-by: Christoph Weitkamp <[email protected]>
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this issue May 5, 2022
…ports timeout 5s and caching) (openhab#10447)

Fixes openhab#10436

Signed-off-by: Christoph Weitkamp <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
1 participant