Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change error_description to error-description #188

Merged
merged 1 commit into from
Mar 9, 2021

Conversation

mantariksh
Copy link
Collaborator

Problem

When there is an error during the MyInfo consent flow, e.g. if the user does not provide consent, MyInfo returns error-description (note hyphen) in the query params, as shown in the screenshots below. However, Mockpass returns error_description (note underscore).

Production

image

Staging

image

Sandbox

image

Solution

Change error_description to error-description.

@mantariksh mantariksh requested a review from LoneRifle March 9, 2021 03:00
Copy link
Collaborator

@LoneRifle LoneRifle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I understand it, MyInfo v2 assumes that the /login endpoint still returns error_description. Given that NDI no longer supports v2 however, I think it's safe to make this breaking change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants