feat: remove MyInfo error_description support #1323
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When the MyInfo consent flow returns an error, we support both
error-description
(note hyphen) anderror_description
(note underscore) in the query parameters. This is because we were previously unsure which one would be returned - the documentation says that it should beerror_description
, but the sandbox and staging APIs both returnederror-description
. Now that we have confirmed that production returnserror-description
as well, we can drop support forerror_description
.Part of #1234
Solution
Drop support for
error_description
. For safety, in case MyInfo decides to add other query parameters, also addunknown(true)
to the Joi validation.Mockpass previously returned
error_description
, but since this PR which went into v2.6.5, it now returnserror-description
, so I upgraded Mockpass to make the dev environment match production.Tests
'MyInfo returned error from consent flow'
) which contains anerrorDescription
.