feat: don't hardcode toast duration #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for objective-bell-0ffbfb canceled.
|
karrui
reviewed
Oct 28, 2022
react/src/Toast/useToast.ts
Outdated
| @@ -36,7 +36,7 @@ export const useToast = ({ | |||
|
|
|||
| const customToastImpl = useMemo(() => { | |||
| const impl = ({ | |||
| duration = 6000, | |||
| duration = initialProps.duration, | |||
There was a problem hiding this comment.
Should we use initial duration props too for consistency?
Should we also add back the default value to prevent duration changes due to this new prop assignment?
There was a problem hiding this comment.
Set the default value via param defaults. Had to rename it to initialDuration, similar to initialStatus
duration: initialDuration = 6000
karrui
approved these changes
Oct 28, 2022
karrui
reviewed
Oct 28, 2022
| ...initialProps | ||
| }: UseToastProps = {}): UseToastReturn => { | ||
| const toast = useChakraToast(initialProps) | ||
|
|
||
| const customToastImpl = useMemo(() => { | ||
| const impl = ({ | ||
| duration = 6000, | ||
| duration = initialDuration, |
There was a problem hiding this comment.
actually this doesn't matter right? this is just a function that we return in useTOast. the user using useToast can override the props themselves (since it is just a function) don't need this PR at all right?
njenwei
added a commit
that referenced
this pull request
Oct 28, 2022
* fix: update vite config to fix downstream build (#103) * fix: update dropdown component to be more reliable (#106) * fix: update dropdown component to be more reliable Linked to a bunch of fixes in the upstream FormSG repository, see: opengovsg/FormSG#5192 opengovsg/FormSG#5137 opengovsg/FormSG#4922 opengovsg/FormSG#4778 * fix: remove unused dependencies * feat: don't hardcode toast duration (#107) * feat: dont hardcode toast duration * feat: set default toast duration * chore: bump package version to 0.0.13-beta.5 Co-authored-by: Kar Rui Lau <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Update
useToastcomponent to accept a duration param.