fix(client): fix logic multiselection dropdown from not showing #5137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix bug where menu would not appear on the screen (since its layout is behind due to pos=absolute)
prevents border from being cut off
now menu is rendered with a portal
Merged
karrui
added a commit
to opengovsg/camp-design-system
that referenced
this pull request
Oct 20, 2022
Linked to a bunch of fixes in the upstream FormSG repository, see: opengovsg/FormSG#5192 opengovsg/FormSG#5137 opengovsg/FormSG#4922 opengovsg/FormSG#4778
karrui
added a commit
to opengovsg/camp-design-system
that referenced
this pull request
Oct 20, 2022
* fix: update dropdown component to be more reliable Linked to a bunch of fixes in the upstream FormSG repository, see: opengovsg/FormSG#5192 opengovsg/FormSG#5137 opengovsg/FormSG#4922 opengovsg/FormSG#4778 * fix: remove unused dependencies
njenwei
added a commit
to opengovsg/camp-design-system
that referenced
this pull request
Oct 28, 2022
* fix: update vite config to fix downstream build (#103) * fix: update dropdown component to be more reliable (#106) * fix: update dropdown component to be more reliable Linked to a bunch of fixes in the upstream FormSG repository, see: opengovsg/FormSG#5192 opengovsg/FormSG#5137 opengovsg/FormSG#4922 opengovsg/FormSG#4778 * fix: remove unused dependencies * feat: don't hardcode toast duration (#107) * feat: dont hardcode toast duration * feat: set default toast duration * chore: bump package version to 0.0.13-beta.5 Co-authored-by: Kar Rui Lau <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Users were unable to select dropdown options in logic builder if the dropdown option was a multi-select. Bug was introduced in #4778 due to library and code changes in rendering of dropdown.
This PR also fixes UI overflow on dropdown menu on long dropdown options.
Solution
Breaking Changes
Improvements:
Bug Fixes: