-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: replace trash icon in MRF steps #7885
Conversation
We can also remove This also means that we have to cascade the removal of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but holding the approval first as I'm getting PM to review the changes in-lieu of Design.
...dmin-form/create/workflow/components/WorkflowContent/InactiveStepBlock/InactiveStepBlock.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Problem
In MRF workflow, blocks have trash icon (top right) giving users ability to delete the step in workflow. For baseline practice in UX, destructive actions should be hidden below the fold
Closes FRM-1905
Solution
Replace trash icon with pencil icon
Update logic upon clicking icon to 'edit step' instead of 'delete step'
First step has pencil icon now also, since users can't delete the first step, but can edit the first step
Users will not be able to click anywhere on the box to enter editing step, only on clicking of the pencil icon
Removed highlight/background change/cursor appearance when hovering the box
Before & After Screenshots