-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: merge release v4.47.0 into master #761
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [lint-staged](https://github.com/okonet/lint-staged) from 10.4.0 to 10.5.1. - [Release notes](https://github.com/okonet/lint-staged/releases) - [Commits](lint-staged/lint-staged@v10.4.0...v10.5.1) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [axios](https://github.com/axios/axios) from 0.20.0 to 0.21.0. - [Release notes](https://github.com/axios/axios/releases) - [Changelog](https://github.com/axios/axios/blob/master/CHANGELOG.md) - [Commits](axios/axios@v0.20.0...v0.21.0) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@types/ejs](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/ejs) from 3.0.4 to 3.0.5. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/ejs) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@types/mongodb](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/mongodb) from 3.5.27 to 3.5.33. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/mongodb) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
chore: merge release v4.46.0 back into develop
Bumps [angular-sanitize](https://github.com/angular/angular.js) from 1.8.1 to 1.8.2. - [Release notes](https://github.com/angular/angular.js/releases) - [Changelog](https://github.com/angular/angular.js/blob/master/CHANGELOG.md) - [Commits](angular/angular.js@v1.8.1...v1.8.2) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [moment-timezone](https://github.com/moment/moment-timezone) from 0.5.31 to 0.5.32. - [Release notes](https://github.com/moment/moment-timezone/releases) - [Changelog](https://github.com/moment/moment-timezone/blob/develop/changelog.md) - [Commits](moment/moment-timezone@0.5.31...0.5.32) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [fp-ts](https://github.com/gcanti/fp-ts) from 2.8.5 to 2.8.6. - [Release notes](https://github.com/gcanti/fp-ts/releases) - [Changelog](https://github.com/gcanti/fp-ts/blob/master/CHANGELOG.md) - [Commits](gcanti/fp-ts@2.8.5...2.8.6) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [mongoose](https://github.com/Automattic/mongoose) from 5.10.14 to 5.10.15. - [Release notes](https://github.com/Automattic/mongoose/releases) - [Changelog](https://github.com/Automattic/mongoose/blob/master/History.md) - [Commits](Automattic/mongoose@5.10.14...5.10.15) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [jwt-decode](https://github.com/auth0/jwt-decode) from 3.1.1 to 3.1.2. - [Release notes](https://github.com/auth0/jwt-decode/releases) - [Changelog](https://github.com/auth0/jwt-decode/blob/master/CHANGELOG.md) - [Commits](auth0/jwt-decode@v3.1.1...v3.1.2) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* feat: expand attachment size choice up to 20mb step 1mb * feat: limit attachment size choice up to 7mb for email mode * chore: slides up to 10mb * refactor: rename EMAIL_MODE_ALLOWED_SIZES
chore: merge Release v4.46.1 hotfix into develop
Bumps [eslint-plugin-jest](https://github.com/jest-community/eslint-plugin-jest) from 24.0.2 to 24.1.3. - [Release notes](https://github.com/jest-community/eslint-plugin-jest/releases) - [Changelog](https://github.com/jest-community/eslint-plugin-jest/blob/master/CHANGELOG.md) - [Commits](jest-community/eslint-plugin-jest@v24.0.2...v24.1.3) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [htmlhint](https://github.com/htmlhint/HTMLHint) from 0.14.1 to 0.14.2. - [Release notes](https://github.com/htmlhint/HTMLHint/releases) - [Changelog](https://github.com/htmlhint/HTMLHint/blob/master/CHANGELOG.md) - [Commits](htmlhint/HTMLHint@v0.14.1...v0.14.2) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@sentry/integrations](https://github.com/getsentry/sentry-javascript) from 5.27.3 to 5.27.4. - [Release notes](https://github.com/getsentry/sentry-javascript/releases) - [Changelog](https://github.com/getsentry/sentry-javascript/blob/master/CHANGELOG.md) - [Commits](getsentry/sentry-javascript@5.27.3...5.27.4) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* feat: add feature request link in admin navbar * feat: update feature request link to go link
* feat: add TOU and PP to public form footer * feat: update privacy policy * feat: update TOU * style: update styling for privacy and tou pages * style: update padding * style: add browser autoprefixes * fix: remove display:table causes display width on ie11 to be unbounded
Bumps [angular-resource](https://github.com/angular/angular.js) from 1.8.1 to 1.8.2. - [Release notes](https://github.com/angular/angular.js/releases) - [Changelog](https://github.com/angular/angular.js/blob/master/CHANGELOG.md) - [Commits](angular/angular.js@v1.8.1...v1.8.2) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [jasmine-core](https://github.com/jasmine/jasmine) from 3.5.0 to 3.6.0. - [Release notes](https://github.com/jasmine/jasmine/releases) - [Changelog](https://github.com/jasmine/jasmine/blob/main/RELEASE.md) - [Commits](jasmine/jasmine@v3.5.0...v3.6.0) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [twilio](https://github.com/twilio/twilio-node) from 3.50.0 to 3.51.0. - [Release notes](https://github.com/twilio/twilio-node/releases) - [Changelog](https://github.com/twilio/twilio-node/blob/main/CHANGES.md) - [Commits](twilio/twilio-node@3.50.0...3.51.0) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@types/mongodb](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/mongodb) from 3.5.33 to 3.5.34. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/mongodb) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* feat(EncryptedSubModel): add findEncryptedSubmissionById static method * test(EncryptSubModel): add tests for findEncryptedSubmissionById * feat: update getMongoErrorMessage to accept unknown type * feat(EncryptSubSvc): add getEncryptedSubmissionData service fn * feat(EncryptSubSvc): add transformAttachmentMetasToSignedUrls fn * test(EncryptSubSvc): add tests for getEncryptedSubmissionData * test(EncryptSubSvc): add test for transformAttachmentMetasToSignedUrls * feat: add logging when error occurs in handleStreamEncryptedResponses * feat(EncryptSubSvc): allow undefined attachmentMeta when transforming * feat(EncryptSubCtl): add handleGetEncryptedResponse * ref(AdminFormsRoutes): replace route handler and remove unused fn * test(EncryptSubCtl: add tests for handleGetEncryptedResponse
* fix: include fieldId in map key * ref: convert Map to fieldId-boolean * ref: improve variable names and docs * test: fix jasmine tests * test: update jest tests
* refactor: neverthrow for checkIsEncryptedEncoding * refactor: remove try-catch for checkIsEncryptedEncoding * fix: add .value to access neverthrown Result * fix: add check for nonceEncrypted * chore: define InvalidEncodingError error class, rename, include full error in log * chore: remove convert try-catch for getProcessedResponses to neverthrown result * refactor: neverthrow for submission service * refactor: neverthrow for validateField * chore: update tests for validateField * chore: limit Error class * chore: update validateEmailSubmission in email submissions server controller * fix: return error from neverthrow error object * chore: add ValidateFieldError class * fix: ConflictError params * chore: update tests for submission.service.spec * chore: remove unnecessary else * refactor: check for err instead of ok * fix: res.sendStatus if no jsosn * docs: update error class JSDocs * docs: update comments * refactor: return true instead of undefined if no error * chore: clean up submission.service tests * chore: clean up tests * chore: update tests
* refactor: migrate homeNoValidator to ts * refactor: update references * doc: rename test * chore: split tests for home and mobile phone numbers
* refactor: standardise usage of getUniqueMyInfoAttrs (#636) * ref: migrate /spcp/redirect endpoint to TypeScript (#635) * refactor: migrate /spcp/validate to TypeScript (#656) * refactor: migrate addSpcpSessionInfo to TypeScript (#664) * refactor: migrate isSpcpAuthenticated to TypeScript (#666) * refactor: create addLoginFromForm static method (#679) * refactor: move passThroughSpcp business logic into service (#667) * refactor: migrate SPCP /login endpoints to TypeScript (#680) * refactor: migrate appendVerifiedSpcpResponses to TypeScript (#693) * docs: add docs for all new functions (#696) * test: add tests for SPCP login endpoints (#695) * feat: log login HTML * fix: change title check to null-only
* feat(adminFormUtils): add methods to assert user permissions on forms * test(adminFormUtils): add remaining tests for assert permissions fns * ref: use adminForm permission util fns when verifying form permissions * feat(adminFormUtils): tighten permission assertion fns scope * test(adminFormUtils): remove tests checking for FormDeletedError * test(AdminFormCtl): rename AuthUtils import to correct AdminFormUtils * test(AdminFormCtl): add form availability error test case
Bumps [@opengovsg/mockpass](https://github.com/opengovsg/mockpass) from 2.5.5 to 2.5.6. - [Release notes](https://github.com/opengovsg/mockpass/releases) - [Commits](opengovsg/mockpass@v2.5.5...v2.5.6) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [sinon](https://github.com/sinonjs/sinon) from 9.2.0 to 9.2.1. - [Release notes](https://github.com/sinonjs/sinon/releases) - [Changelog](https://github.com/sinonjs/sinon/blob/master/CHANGELOG.md) - [Commits](https://github.com/sinonjs/sinon/commits) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* feat(FeedbackSvc): add getFormFeedbackCount fn (and tests) * feat(AdminFormCtl): add handleCountFormFeedback handler fn * test(AdminFormCtl): add tests for handleCountFormFeedback * ref(AdminFormRoutes): use new handleCountFormFeedback fn * feat(AdminFormCtl): include assertFormAvailable check in chain * test(AdminFormCtl): add form availability error test case
* feat: expand attachment size choice up to 20mb step 1mb * feat: limit attachment size choice up to 7mb for email mode * chore: slides up to 10mb * refactor: rename EMAIL_MODE_ALLOWED_SIZES * feat: limit attachment size intervals to 1,2,3,7,10,20 * feat: shift size guidance to tooltip * chore: update attachment size tooltip copy
mantariksh
approved these changes
Dec 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.